Don't use Preferences from CompositorLRU

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

(Blocks: 1 bug)

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment, 1 obsolete attachment)

This breaks GPU process.
Created attachment 8771852 [details] [diff] [review]
patch

gfxPrefs is initialized after the layout module, so I had to move CompositorLRU::Init.

Alternately we could just delete the whole thing since it's a b2g-only optimization.
Attachment #8771852 - Flags: review?(matt.woodrow)
Comment on attachment 8771852 [details] [diff] [review]
patch

Review of attachment 8771852 [details] [diff] [review]:
-----------------------------------------------------------------

I would also be ok with deleting it.
Attachment #8771852 - Flags: review?(matt.woodrow) → review+

Comment 3

2 years ago
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3924432ba21
Don't access Preferences from CompositorLRU. (bug 1287362, r=mattwoodrow)
backed out for crashes like https://treeherder.mozilla.org/logviewer.html#?job_id=32071114&repo=mozilla-inbound
Flags: needinfo?(dvander)

Comment 5

2 years ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/777e1b279e39
Backed out changeset b3924432ba21 for xpcshell crashes
Created attachment 8772631 [details] [diff] [review]
rm

Two strikes, let's remove it.
Attachment #8771852 - Attachment is obsolete: true
Flags: needinfo?(dvander)
Attachment #8772631 - Flags: review?(matt.woodrow)
Attachment #8772631 - Flags: review?(matt.woodrow) → review+

Comment 7

2 years ago
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddbf5e3673c4
Remove CompositorLRU and associated code. (bug 1287362, r=mattwoodrow)

Updated

2 years ago
Whiteboard: [gfx-noted]

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ddbf5e3673c4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.