1287366 - Add ImageBridge support to the GPU process

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

This will look similar to bug 1282348.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, move init

This moves ImageBridge initialization a little later, to when we first request a layer manager. That makes it easier to bind it to the right process. I think this should be okay since we shouldn't be using it without some kind of layer tree existing somewhere.

This patch also cleans up some gross initialization code.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 2, use Endpoints

This changes PContent to initialize ImageBridges with endpoints instead of the old "opens" feature.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 2, use Endpoints

err, correct patch.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 3, gpu proc support

This instantiates ImageBridgeParent in the GPU process and provides Endpoint connections from the UI process and content processes.

With this video appears to work.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8771886 [details] [diff] [review]
part 2, use Endpoints

Review of attachment 8771886 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/ImageBridgeChild.cpp
@@ +916,5 @@
>  
>    sImageBridgeChildSingleton = new ImageBridgeChild();
> +
> +  MessageLoop* loop = sImageBridgeChildSingleton->GetMessageLoop();
> +  

Whitespace

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56f707cd8725
Move parent-process ImageBridgeChild startup to GPUProcessManager. (bug 1287366 part 1, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4a1a01e9eda
Use Endpoints for content-process ImageBridges. (bug 1287366 part 2, r=billm)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0f0837ba27d
Implement ImageBridge support for the GPU process. (bug 1287366 part 3, r=mattwoodrow,billm)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/56f707cd8725
https://hg.mozilla.org/mozilla-central/rev/f4a1a01e9eda
https://hg.mozilla.org/mozilla-central/rev/a0f0837ba27d