Closed Bug 1287366 Opened 4 years ago Closed 4 years ago

Add ImageBridge support to the GPU process

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

This will look similar to bug 1282348.
This moves ImageBridge initialization a little later, to when we first request a layer manager. That makes it easier to bind it to the right process. I think this should be okay since we shouldn't be using it without some kind of layer tree existing somewhere.

This patch also cleans up some gross initialization code.
Attachment #8771881 - Flags: review?(matt.woodrow)
Attached patch part 2, use Endpoints (obsolete) — Splinter Review
This changes PContent to initialize ImageBridges with endpoints instead of the old "opens" feature.
Attachment #8771882 - Flags: review?(wmccloskey)
err, correct patch.
Attachment #8771882 - Attachment is obsolete: true
Attachment #8771882 - Flags: review?(wmccloskey)
Attachment #8771886 - Flags: review?(wmccloskey)
This instantiates ImageBridgeParent in the GPU process and provides Endpoint connections from the UI process and content processes.

With this video appears to work.
Attachment #8771898 - Flags: review?(wmccloskey)
Attachment #8771898 - Flags: review?(matt.woodrow)
Attachment #8771881 - Flags: review?(matt.woodrow) → review+
Attachment #8771898 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8771886 [details] [diff] [review]
part 2, use Endpoints

Review of attachment 8771886 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/ImageBridgeChild.cpp
@@ +916,5 @@
>  
>    sImageBridgeChildSingleton = new ImageBridgeChild();
> +
> +  MessageLoop* loop = sImageBridgeChildSingleton->GetMessageLoop();
> +  

Whitespace
Attachment #8771886 - Flags: review?(wmccloskey) → review+
Attachment #8771898 - Flags: review?(wmccloskey) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56f707cd8725
Move parent-process ImageBridgeChild startup to GPUProcessManager. (bug 1287366 part 1, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4a1a01e9eda
Use Endpoints for content-process ImageBridges. (bug 1287366 part 2, r=billm)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0f0837ba27d
Implement ImageBridge support for the GPU process. (bug 1287366 part 3, r=mattwoodrow,billm)
https://hg.mozilla.org/mozilla-central/rev/56f707cd8725
https://hg.mozilla.org/mozilla-central/rev/f4a1a01e9eda
https://hg.mozilla.org/mozilla-central/rev/a0f0837ba27d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.