Can't request needinfo from someone when I'm needinfo'd on a bug

RESOLVED FIXED

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Gijs, Assigned: dkl)

Tracking

Production

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Sometimes I want to keep my own needinfo when also requesting info from other people. The modal UI gives me no way to do that, because my only options are "clear needinfo" and "redirect needinfo", not "keep needinfo and also request needinfo from these other people".
It doesn't seem to be Modal UI specific. It exists even without enabling Modal.

And yeah, this is annoying. In addition, if people do not notice that "Need more information from" changes to "Redirect my needinfo request to" when they uncheck "Clear the needinfo request for", they may clear the needinfo request without knowing that, which I've met several times before.
Component: User Interface: Modal → Extensions: Needinfo
(Assignee)

Updated

2 years ago
Assignee: nobody → dkl
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8813392 [details] [diff] [review]
1287461_1.patch
Attachment #8813392 - Flags: review?(dylan)
Comment on attachment 8813392 [details] [diff] [review]
1287461_1.patch

Review of attachment 8813392 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

fix nit on commit :)

::: extensions/Needinfo/Extension.pm
@@ +92,4 @@
>      Bugzilla->input_params($params);
>  
>      my $add_needinfo  = delete $params->{needinfo};
> +    my $needinfo_type = delete $params->{needinfo_type};

nit: add // '' to prevent uninit'd warning in string comparison.
Attachment #8813392 - Flags: review?(dylan) → review+
(Assignee)

Comment 4

2 years ago
To https://github.com/mozilla-bteam/bmo.git
   fe64441..6d01972  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.