Closed Bug 128748 Opened 24 years ago Closed 24 years ago

[xlib] Sync Xlib gfx with GTK+ gfx source

Categories

(Core :: XUL, enhancement, P1)

Product:
Core
Component:
XUL
Platform:
All
Linux
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.0

People

(Reporter: roland.mainz, Assigned: roland.mainz)

References

Details

Attachments

(1 file, 2 obsolete files)

New patch for 2002-02-28-08-trunk per timeless's review comments
236.78 KB, patch
attinasi
: superreview+
asa
: approval+
Details | Diff | Splinter Review
We need to sync nsFontMetricsXlib with nsFontMetricsGTK to make it easier to port code from GTK+ --> Xlib gfx later...
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.0
Attached patch Patch for 2002-03-03-08-trunk (obsolete) — — Splinter Review
Requesting r=/sr=/a{trunk}= ...
Keywords: patch, review
Attachment #72326 - Attachment is obsolete: true
Blocks: 79119
Summary: Sync nsFontMetricsXlib with nsFontMetricsGTK source → [xlib] Sync Xlib gfx with GTK+ gfx source
Attachment #72499 - Attachment is obsolete: true
i made a few comments, but basically this is another gtk syncing. tentative r=timeless pending an sr= from attinasi.
Comment on attachment 72540 [details] [diff] [review] New patch for 2002-02-28-08-trunk per timeless's review comments sr=attinasi, assuming you have built it in all relevant configurations
Attachment #72540 - Flags: superreview+
Marc Attinasi wrote: > assuming you have built it in all relevant configurations Yes, I did. I tried it with and without Xprint support enabled, with a StaticBuild and with two compilers (gcc and Sun Workshop) ...
Blocks: 119491
Comment on attachment 72540 [details] [diff] [review] New patch for 2002-02-28-08-trunk per timeless's review comments a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72540 - Flags: approval+
Blocks: 85417
Fix checked in, marking bug as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Roland: I thought that the reason to have x11shared was to not replicate code.. Is there a bug open to finish this? From attachment 72540 [details] [diff] [review]: +/* XXX: We can't include gfx/src/x11shared/nsFreeType.h because it relies on + * GDK/GTK+ includes which are not available in Xlib builds (fix is to remove + * the GDK/GTK+ dependicy from the code in gfx/src/x11shared/ ...) + */
bstell wrote: > Roland: I thought that the reason to have x11shared was to not replicate > code.. Yes... that was the reason... > Is there a bug open to finish this? No... can you file one, please ?
Brian Stell wrote: > I've opened bug 145043 Thanks!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: