Closed Bug 128749 Opened 23 years ago Closed 23 years ago

Shortcut keys non-functional in outliner

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.0

People

(Reporter: bryner, Assigned: bryner)

References

Details

Attachments

(1 file)

Due to outliner's keypress handler for the ' ' character, and some ECMA oddities, we are _always_ executing the handler for the space key. This affects XBL select widgets as well. Patch coming up.
This blocks XBL form controls being turned on, since we break keyboard access in a big way.
Blocks: 57209
Status: NEW → ASSIGNED
Keywords: nsbeta1
Summary: Shortcut keys non-function in outliner → Shortcut keys non-functional in outliner
Target Milestone: --- → mozilla1.0
Attached patch patchSplinter Review
a suggestion from shaver's bag of tricks
Actually, to clarify, we are always executing the handler if the keycode is 0, such as for control-key combinations.
Comment on attachment 72328 [details] [diff] [review] patch sr=blake
Attachment #72328 - Flags: superreview+
Attachment #72328 - Flags: approval+
Comment on attachment 72328 [details] [diff] [review] patch a=asa (on behalf of drivers) for checkin to the 1.0 trunk
checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
nsbeta1+, in case it gets reopened.
Keywords: nsbeta1nsbeta1+
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: