1287508 - New console frontend: Add filter bar

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Lin Clark [:linclark]]

See https://github.com/devtools-html/gecko-dev/issues/101

Comment 1

[Lin Clark [:linclark]]

Attachment: Bug 1287508 - Part 1: New console frontend: Add filter bar.

Review commit: https://reviewboard.mozilla.org/r/66868/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66868/

Comment 2

[Lin Clark [:linclark]]

Attachment: Bug 1287508 - Part 2: Update scroll pinning.

Review commit: https://reviewboard.mozilla.org/r/66870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66870/

Comment 3

[Lin Clark [:linclark]]

Attachment: Bug 1287508 - Part 3: Define state defaults in reducers.

Review commit: https://reviewboard.mozilla.org/r/66872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66872/

Comment 4

[Lin Clark [:linclark]]

Attachment: Bug 1287508 - Part 4: Fix CSS for the FilterBar.

Review commit: https://reviewboard.mozilla.org/r/66874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66874/

Comment 5

[Lin Clark [:linclark]]

Comment on attachment 8774390 [details]
Bug 1287508 - Part 1: New console frontend: Add filter bar.

https://reviewboard.mozilla.org/r/66868/#review63620

Comment 6

[Lin Clark [:linclark]]

Comment on attachment 8774392 [details]
Bug 1287508 - Part 3: Define state defaults in reducers.

https://reviewboard.mozilla.org/r/66872/#review63622

Comment 7

[Lin Clark [:linclark]]

Comment on attachment 8774393 [details]
Bug 1287508 - Part 4: Fix CSS for the FilterBar.

https://reviewboard.mozilla.org/r/66874/#review63624

Comment 8

[Tim Nguyen :ntim]

Comment on attachment 8774393 [details]
Bug 1287508 - Part 4: Fix CSS for the FilterBar.

https://reviewboard.mozilla.org/r/66874/#review64012

::: devtools/client/webconsole/new-console-output/components/filter-bar.js:66
(Diff revision 1)
>            configFilterBarVisible ? " active" : ""),
>          title: "Toggle filter bar",
>          onClick: this.onToggleFilterConfigBarButtonClick
>        }),
>        dom.input({
> -        className: "devtools-searchinput",
> +        className: "devtools-plain-input",

nit: .devtools-plaininput (instead of .devtools-plain-input) for consistency with other input classes

Comment 9

[Brian Grinstead [:bgrins]]

Comment on attachment 8774390 [details]
Bug 1287508 - Part 1: New console frontend: Add filter bar.

https://reviewboard.mozilla.org/r/66868/#review64046

Comment 10

[Brian Grinstead [:bgrins]]

Comment on attachment 8774391 [details]
Bug 1287508 - Part 2: Update scroll pinning.

https://reviewboard.mozilla.org/r/66870/#review64048

As discussed, let's wait on landing until after merge day

Comment 11

[Lin Clark [:linclark]]

Attachment: Bug 1287508 - Part 5: Fix CSS rules and classes for the FilterBar.

Review commit: https://reviewboard.mozilla.org/r/68304/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68304/

Comment 12

[Lin Clark [:linclark]]

Comment on attachment 8776590 [details]
Bug 1287508 - Part 5: Fix CSS rules and classes for the FilterBar.

https://reviewboard.mozilla.org/r/68304/#review65350

Comment 13

[Lin Clark [:linclark]]

If tests pass, I'll land this today.

Comment 14

[Tim Nguyen :ntim]

Comment on attachment 8776590 [details]
Bug 1287508 - Part 5: Fix CSS rules and classes for the FilterBar.

https://reviewboard.mozilla.org/r/68304/#review65352

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45170a42e54c
Part 1: New console frontend: Add filter bar. r=bgrins
https://hg.mozilla.org/integration/autoland/rev/26c34b9a3fd3
Part 2: Update scroll pinning. r=bgrins
https://hg.mozilla.org/integration/autoland/rev/9968225662d3
Part 3: Define state defaults in reducers. r=me
https://hg.mozilla.org/integration/autoland/rev/1ff528cb9e15
Part 4: Fix CSS for the FilterBar. r=ntim
https://hg.mozilla.org/integration/autoland/rev/6db7f11e05a6
Part 5: Fix CSS rules and classes for the FilterBar. r=ntim

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/45170a42e54c
https://hg.mozilla.org/mozilla-central/rev/26c34b9a3fd3
https://hg.mozilla.org/mozilla-central/rev/9968225662d3
https://hg.mozilla.org/mozilla-central/rev/1ff528cb9e15
https://hg.mozilla.org/mozilla-central/rev/6db7f11e05a6

Comment 17

[Nazir Ahmed Sabbir [:NaSb]]

Managed to reproduce this bug on Nightly 50.0a1 (2016-07-18) (Build ID: 20160718030454) on Linux.

This Bug's Fix is now verified on Latest Firefox Nightly 51.0a1 (2016-08-23)

Build ID: 20160823072522
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
OS: Linux 4.4.0-2-deepin-amd64