Closed
Bug 1287522
Opened 7 years ago
Closed 7 years ago
Wrong evaluation order in RegExp.prototype.toString
Categories
(Core :: JavaScript: Standard Library, defect)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla50
People
(Reporter: anba, Assigned: arai)
References
()
Details
Attachments
(1 file)
2.31 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
ToString needs to be applied before retrieving the "flags" property. Test case: --- RegExp.prototype.toString.call({ get source() { print("get source"); return {toString() {print("source-tostring")}}; }, get flags() { print("get flags"); return {toString() {print("flags-tostring")}}; }, }); --- Expected: Prints "source-tostring" before "get flags" Actual: Prints "source-tostring" after "get flags"
Assignee | ||
Comment 1•7 years ago
|
||
Added explicit ToString call to pattern and flags, in correct order, and renumbered the spec steps.
Assignee: nobody → arai.unmht
Attachment #8772226 -
Flags: review?(evilpies)
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Blocks: 1079919
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox49:
--- → affected
status-firefox-esr45:
--- → affected
Updated•7 years ago
|
Attachment #8772226 -
Flags: review?(evilpies) → review+
Assignee | ||
Comment 2•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/49bef2408c15ae8e76ee485bd8c338573fa8a1c7 Bug 1287522 - Apply ToString in correct order in RegExp.prototype.toString. r=evilpie
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/49bef2408c15
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•