Update FF 44/45/46/47/48 with a stub Hello add-on that removes the Hello button

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: RT, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

User Story

Background: 
Hello will be removed from FF49 and we have the ability to remove the Hello button for FF44/45/46/47/48 users since these releases use the Hello system add-on.

Acceptance criteria:
- Remove Hello button from Firefox toolbar or customize menu for all users of Firefox 44, 45, 46, 47 and 48
- Go Faster update planned post FF49 launch

ESR Clarifications: Hello was always disabled from ESR builds by default. We won't update ESR builds.

Attachments

(3 attachments)

Comment hidden (empty)
(Reporter)

Updated

2 years ago
Group: mozilla-employee-confidential
(Reporter)

Updated

2 years ago
User Story: (updated)
Summary: Update FF45/46/47/48 users of the Hello add-on → Update FF45/46/47/48 with a stub Hello add-on that removes the Hello button
(Reporter)

Updated

2 years ago
User Story: (updated)
(Reporter)

Updated

2 years ago
Blocks: 1287826
(Assignee)

Comment 1

2 years ago
Taking, whilst I find out if we need to do a stub, or if we can just kill the add-on via a specially crafted update message.

For ESR I don't think we should do anything (it is disabled by default), unless we suspect usage there - although ESR38 we couldn't do anything about anyway.
Assignee: nobody → standard8
(Reporter)

Comment 2

2 years ago
Thanks Mark, added clarification regarding ESR in the user story. I agree we should not deal with ESR builds as part of this bug.
User Story: (updated)
(Assignee)

Comment 3

2 years ago
Created attachment 8790245 [details]
AMO addon: 2.5.0 uninstall itself.

This is an add-on that I'll upload to AMO after 49 hits. It will simply uninstall itself - so that any users who installed the "Beta" add-on will get it automatically removed.
(Assignee)

Comment 4

2 years ago
Created attachment 8790246 [details]
Firefox System Addon v3.0.0 - disable Hello

This is an add-on that will disable Hello:

* For 44 it'll set the preference to disabled (since Hello wasn't an add-on at that time).
* For 45 - 48, it is effectively an empty add-on that will get installed over the top of the built-in add-on, or previously updated Hello system add-on. Hence, it'll disable Hello by the code effectively not being there.
(Assignee)

Comment 5

2 years ago
Created attachment 8790247 [details] [diff] [review]
Source files for "Firefox System Addon v3.0.0 - disable Hello"

Rob, please see comment 4 for what these files are intended to do. Can you give these a quick once-over please?
Attachment #8790247 - Flags: review?(rhelmer)
(Assignee)

Updated

2 years ago
Summary: Update FF45/46/47/48 with a stub Hello add-on that removes the Hello button → Update FF 44/45/46/47/48 with a stub Hello add-on that removes the Hello button
(Reporter)

Comment 6

2 years ago
Updating user story to reflect the fact we now include FF44 users as part of this bug.
User Story: (updated)
Attachment #8790247 - Flags: review?(rhelmer) → review+
(Assignee)

Updated

2 years ago
Depends on: 1302217

Comment 7

2 years ago
Hi Mark, Sylvestre, should we relnote this in Fx48 release notes?
Flags: needinfo?(standard8)
Flags: needinfo?(sledru)
(Reporter)

Comment 8

2 years ago
(In reply to Ritu Kothari (:ritu) from comment #7)
> Hi Mark, Sylvestre, should we relnote this in Fx48 release notes?

I assume we need to update release notes of FF44 through to FF48 with something similar to what we have for FF49 ("Firefox Hello being decommissioned" linking to "https://support.mozilla.org/en-US/kb/hello-status" in the "New" category?
(Assignee)

Comment 9

2 years ago
I've now got this up partially on the release-sysaddon channel for particular versions. I've not done 46 nor 47 yet, I've got a little bit more work to do on those.

Notes:

- For all of these, about:support should list Firefox Hello as version 3.0.0.
- On 44.* the `loop.enabled` preference will be false.
- On 45.* (not esr), 48.*, the preference is not set, as the updated version 3.0.0 (which is a bare extension) will override the built-in version of the system add-on.
Flags: needinfo?(standard8)
(Assignee)

Updated

2 years ago
Depends on: 1302724
(Assignee)

Updated

2 years ago
Depends on: 1303125
(Assignee)

Comment 10

2 years ago
FF 46.0/46.0.1/47.0/47.0.1 should also be set up now.
I don't think we need to update old release notes because they describes a past version and it is part of history.
We should limit the update to 48 & 49 (which I just did).
Flags: needinfo?(sledru)
(Assignee)

Comment 12

2 years ago
We now have 3.1.0 of the Hello add-on for 44.* and 45.* - it hides the menu option as noted per bug 1303729.

This is now on the release-sysaddon channel and ready for QA to re-test.
Flags: needinfo?(bogdan.maris)
We finished testing 44.* and 45.* across platforms (Windows 10 64bit, Windows 7 64-bit, Mac OS X 10.11.2 and Ubuntu 16.04 32-bit), the update is successfully made to v3.1.0 and bug 1303729 was verified. 
For the other versions 46.*, 47.* and 48.*, update is made to v3.0.0 and Hello is disabled successfully.
Flags: needinfo?(bogdan.maris)
(Assignee)

Comment 14

2 years ago
This is now shipping - 3.1.0 to 44 & 45, 3.0.0 to 46 through 48.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Group: mozilla-employee-confidential
You need to log in before you can comment on or make changes to this bug.