Closed
Bug 1287541
Opened 8 years ago
Closed 8 years ago
Try eliminating unnecessary asan flags
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
Details
Attachments
(1 file)
|
1.54 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
The asan configuration has -fPIC and -Dxmalloc=myxmalloc, neither of which seem to be necessary.
ehsan, nfroyd, and mccr8 all said they didn't know what they were for and just cargo-culted them.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8772112 -
Flags: review?(mh+mozilla)
|
||
Updated•8 years ago
|
Attachment #8772112 -
Flags: review?(mh+mozilla) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad246624295e
Eliminate unnecessary asan flags, r=glandium
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•