Closed Bug 1287541 Opened 4 years ago Closed 4 years ago

Try eliminating unnecessary asan flags

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file)

The asan configuration has -fPIC and -Dxmalloc=myxmalloc, neither of which seem to be necessary.

ehsan, nfroyd, and mccr8 all said they didn't know what they were for and just cargo-culted them.
Attachment #8772112 - Flags: review?(mh+mozilla) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad246624295e
Eliminate unnecessary asan flags, r=glandium
https://hg.mozilla.org/mozilla-central/rev/ad246624295e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.