1287542 - stylo: Keep track of whether we have pending restyles.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

With Bug 1286445 landed, this is now easy.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1287542: stylo: Implement ServoRestyleManager::HasPendingRestyles()

Review commit: https://reviewboard.mozilla.org/r/65016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65016/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1287542: stylo: Actually post a restyle event to the restyle manager on content state change.

This was somehow a leftover from Bug 1286445.

Review commit: https://reviewboard.mozilla.org/r/65018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65018/

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8772120 [details]
Bug 1287542: stylo: Implement ServoRestyleManager::HasPendingRestyles()

https://reviewboard.mozilla.org/r/65016/#review62012

We should just check the bit on the document here rather than introducing a new piece of state that could get out of sync.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8772121 [details]
Bug 1287542: stylo: Actually post a restyle event to the restyle manager on content state change.

https://reviewboard.mozilla.org/r/65018/#review62014

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8772120 [details]
Bug 1287542: stylo: Implement ServoRestyleManager::HasPendingRestyles()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65016/diff/1-2/

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8772121 [details]
Bug 1287542: stylo: Actually post a restyle event to the restyle manager on content state change.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65018/diff/1-2/

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8772120 [details]
Bug 1287542: stylo: Implement ServoRestyleManager::HasPendingRestyles()

https://reviewboard.mozilla.org/r/65016/#review62064

r=me with those two fixes.

::: layout/base/ServoRestyleManager.h:82
(Diff revision 2)
> +  bool mHasPendingRestyles;
> +

This should go away.

::: layout/base/ServoRestyleManager.cpp:155
(Diff revision 2)
> +  // NB: we restyle from the root element, but the document also gets the
> +  // HAS_DIRTY_DESCENDANTS flag as part of the loop on PostRestyleEvent, and we
> +  // use that to check we have pending restyles.
> +  //
> +  // Thus, they need to get cleared here.
> +  doc->UnsetFlags(NODE_HAS_DIRTY_DESCENDANTS_FOR_SERVO);

Let's move this down so that we set it when the document no longer has dirty descendants. Also, let's just assert that the document is never dirty.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8772120 [details]
Bug 1287542: stylo: Implement ServoRestyleManager::HasPendingRestyles()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65016/diff/2-3/

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8772121 [details]
Bug 1287542: stylo: Actually post a restyle event to the restyle manager on content state change.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65018/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2566472bdbe7
stylo: Implement ServoRestyleManager::HasPendingRestyles() r=bholley
https://hg.mozilla.org/integration/autoland/rev/ab4766520512
stylo: Actually post a restyle event to the restyle manager on content state change. r=bholley

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2566472bdbe7
https://hg.mozilla.org/mozilla-central/rev/ab4766520512