1287599 - mozharness archive extraction could be more convenient

Status: RESOLVED DUPLICATE of bug 1258539

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Geoff Brown [:gbrown]]

Sometimes when I am experimenting with new archives - like a new android emulator archive - I accidentally use a different archive format (like zip vs tar) or a different filename extension (like .tgz instead of .tar.gz) and that almost always results in a failed try push - what a waste!

We can make mozharness archive extraction more forgiving / more convenient.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: introduce download_unpack

This adds download_unpack(), which will handle either .zip or .tar-based archives. unpack() is expanded to allow for ".tgz" and ".tar" in addition to ".tar.gz" and ".tar.bz2".

The existing download_unzip() is restructured but is functionally unchanged.

I use download_unpack() from the android emulator installation only, for now. If download_unpack() works well for the emulator, we may expand its use to other contexts in future.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please also see bug 1258539 which has a patch referenced Armen wants to get finished and landed soon.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 8772166 [details] [diff] [review]
introduce download_unpack

I wasn't aware of whimboo's work -- let's wait and see how that works out.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that with my upcoming patch on bug 1258539 we do no longer check for file extensions but actually file types this won't be a problem anymore for you. I will mark this bug as duplicate.