1287661 - Investigate the mimeType.rdf usage of helperApp.js

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Alphan Chen [:alchen]]

helperApps.js is a consumer of mimeType.rdf. We need to make the function work when we use mimeType.json to replace mimeType.rdf.

Comment 1

[William Hsu [:whsu]]

Set priority to P2 because we're going to implement this feature on Firefox 52.
@ Development Schedule: https://docs.google.com/spreadsheets/d/1WznJUt7lLvcZwwry0yvJ_-hw0ZAXTxOOvmYCw74uGKY/edit#gid=0

Comment 2

[Eden Chuang[:edenchuang]]

Currently we found that HelperApps.js and its related testcases directly access mimeTypes.rdf through nsIRDFService. These actions are not expected, they should be done through the nsIHandlerSerivce. However, nsIHandlerService::store() is useless.

HelperApps.js accesses mimeTypes.rdf to save the file extension attribute. The file extension is not the member of nsIHandlerInfo, but is a member of nsIMIMEInfo which is an extension of nsIHandlerInfo. Because nsIHandlderService only deals the nsIHandlerInfo, this is the root cause why nsIHandlerSerivce::store is useless for saving file extension.

The next step, I will analyze the necessity of saving file extension first. If the answer is yes, I will integrate the file extension saving into nsIHandlerService. Otherwise, the corresponding code in HelperApps.js and its related testcases will be removed.

Comment 3

[Eden Chuang[:edenchuang]]

After investigation, I think we can use nsIHandlerService::Store() to replace the HelperApps.js in nsHelperAppDlg.js. HelperApps.js is used to store the selected handler information into mimeTypes.rdf, and it is almost the same with what nsIHandlerService does. After testing by manually, there is no difference in mimeTypes.rdf results between using HelperApps.js and nsIHandlerService::Store(). So I suggest we can replace HelperApps.js by nsIHandlerService.

Comment 4

[:Paolo Amadini]

(In reply to Eden Chuang[:edenchuang] from comment #3)
> After testing by manually, there
> is no difference in mimeTypes.rdf results between using HelperApps.js and
> nsIHandlerService::Store(). So I suggest we can replace HelperApps.js by
> nsIHandlerService.

Sounds good, we should just ensure that we have automated tests that cover the code path that currently uses HelperApps.js. If there isn't one, we can write one in this bug.

Comment 5

[Eden Chuang[:edenchuang]]

The patch implementation will be traced on bug 1287664. HelperApps.js has its own test cases, I will make sure these test cases are passed. Of course, if new test cases are needed, I will also write corresponding one for testing.