Closed Bug 1287765 Opened 3 years ago Closed 3 years ago

Decide what 'learn more' link for containers in about:preferences should point to.

Categories

(Core :: DOM: Security, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Whiteboard: [userContextId])

Attachments

(1 file)

No description provided.
Depends on: 1279029
We need a sumo page on Containers.  baku, in the meantime you can use the wiki page.

Hi Joni,

We have been working on a feature called Containers[1].  It is an experimental feature and we are creating preference for it in about:preferences#privacy.  Along with the preference, we want to add a Learn More link.  How do we go about createing a sumo page for Containers and how do we get the corresponding url that we should emebed within the codebase?  Thanks for your help!

[1] https://wiki.mozilla.org/Security/Contextual_Identity_Project/Containers
Flags: needinfo?(jsavage)
Whiteboard: [userContextId]
Hi Tanvi,

I created a placeholder slug on SUMO. Here's the URL you can use for the Learn More link: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/containers

When would we need the content up? Since it's an experiment, we generally wouldn't localize it unless it's a high visibility/publicity. Who would like to work on the first draft? Should I do it, or would you like to?
Flags: needinfo?(jsavage) → needinfo?(tanvi)
Attached patch pref3.patchSplinter Review
Assignee: nobody → amarchesini
Attachment #8772594 - Flags: review?(gijskruitbosch+bugs)
Thanks Joni!  Yes, I do not want to localize it yet.  We just need something basic as a place holder.  It can even link to the wiki page for more information.  If you have time to populate some content, that would be great!  If not, the placeholder URL is fine for now.  Thank you!
Flags: needinfo?(tanvi) → needinfo?(jsavage)
Comment on attachment 8772594 [details] [diff] [review]
pref3.patch

Review of attachment 8772594 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/in-content/privacy.xul
@@ +293,5 @@
>  <groupbox id="browserContainersGroup" data-category="panePrivacy" hidden="true">
>    <vbox id="browserContainersbox" hidden="true">
> +    <caption><label>&browserContainersHeader.label;
> +      <label id="browserContainersLearnMore" class="text-link"
> +             value="&browserContainersLearnMore.label;"/>

Flod, can you remind me if this works for l10n and/or how you would suggest doing it differently for HTML/XUL/DTD ? Do we just need an "after" entity, and no space between the entity before the link and after the link?
Attachment #8772594 - Flags: review?(gijskruitbosch+bugs) → review?(francesco.lodolo)
I don't know if it helps, but I did copy&paste from another similar caption+label.
Comment on attachment 8772594 [details] [diff] [review]
pref3.patch

Review of attachment 8772594 [details] [diff] [review]:
-----------------------------------------------------------------

I assume you copied it from the Tracking Protection section
https://hg.mozilla.org/mozilla-central/file/d22b099cf1e3/browser/components/preferences/in-content/privacy.xul#l98

Since the CSS is the same, it's OK.

One example of not-so-good "Learn more" is in Content-Notifications, that one looks part of the sentence (and out of place as a consequence).
Attachment #8772594 - Flags: review?(francesco.lodolo) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/759e68fea547
Add 'learn more' in about:preferences for Containers, r=gijsm r=flod
https://hg.mozilla.org/mozilla-central/rev/759e68fea547
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
We have a draft up of the article now: https://support.mozilla.org/kb/containers-experiment

The in-product link will automatically point to it.

If you have any suggestions, please add them here: https://docs.google.com/a/mozilla.com/document/d/1s9gEO7lnS4kaf8roNq558VeqnaE2_AWOOWyNRfBBCYk/edit?usp=sharing
Flags: needinfo?(jsavage)
Great work Joni!  Thank you!  I made a few comments for fixes in the google doc.
Flags: needinfo?(jsavage)
Thanks, Tanvi! I've updated the article with your suggestions.
Flags: needinfo?(jsavage)
Hi Joni,

We would like to add another section at the bottom of the containers sumo page that will explain to users that the feature will be disabled when:

* using Private Browsing mode
* enabling "Never Remember History" under about:preferences#privacy

When either of these two features are being used, all the container access points will be greyed out and disabled.
Flags: needinfo?(jsavage)
Hi Kamil, I've added info on when the feature is disabled. I put it closer to the top near how to enable containers so users know right away that it won't work if they're in private browsing or have their browser set to never remember history.

Please let me know if there's anything else.
Flags: needinfo?(jsavage)
Thanks Joni! Would you be able to change the current wording to the following instead:

"Note that Containers is disabled in https://support.mozilla.org/en-US/kb/private-browsing-use-firefox-without-history and when Never Remember History is selected in your privacy preferences."

Thanks again :)
Flags: needinfo?(jsavage)
Sure thing, Kamil. All set.
Flags: needinfo?(jsavage)
Awesome, thanks. Last thing, promise! Could you replace the ":" at the end of the sentence with a period instead?
Flags: needinfo?(jsavage)
Oops, yes, all set. Thanks for catching that.
Flags: needinfo?(jsavage)
Looks great! Thanks again Joni.
You need to log in before you can comment on or make changes to this bug.