Closed Bug 1287825 Opened 4 years ago Closed 4 years ago

Remove nsCertVerificationThread.h from includes after bug 1284946

Categories

(MailNews Core :: Security, defect, blocker)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

(Keywords: dogfood)

Attachments

(1 file)

The build fails with: z:/Mozilla/comm-central/mailnews/mime/src/nsCMS.cpp(12): fatal error C1083: Cannot open include file: 'nsCertVerificationThread.h': No such file or directory
Attached patch Bug1287825.patchSplinter Review
With only removing the include it builds again and TB is working with no issue for me. I don't know if something else is needed.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8772429 - Flags: review?(mkmelin+mozilla)
Severity: normal → blocker
Sorry - I forgot to check for instances of what bug 1284946 was going to remove in comm-central. Along those lines, it looks like the nsIX509Cert constants VERIFIED_OK, NOT_VERIFIED_UNKNOWN, etc. will have to be dealt with here: https://dxr.mozilla.org/comm-central/rev/752a2122c521c5115049f4fbb4229484a05b2c2c/mailnews/extensions/smime/content/msgCompSecurityInfo.js#24
As far as I can tell, that function is only being used from line 204 of that file. The values passed to it come from the call to nsISMimeJSHelper.getRecipientCertsInfo on line 89. Looking at the implementation, those values appear to all just be 0: https://dxr.mozilla.org/comm-central/source/mailnews/extensions/smime/src/nsSMimeJSHelper.cpp#97 so this implementation can be simplified somewhat.
Comment on attachment 8772429 [details] [diff] [review]
Bug1287825.patch

Review of attachment 8772429 [details] [diff] [review]:
-----------------------------------------------------------------

rs=mkmelin
Attachment #8772429 - Flags: review?(mkmelin+mozilla) → review+
https://hg.mozilla.org/comm-central/rev/e8d79693a47a
Target Milestone: --- → Thunderbird 50.0
(In reply to David Keeler [:keeler] (use needinfo?) from comment #2)
> Sorry - I forgot to check for instances of what bug 1284946 was going to
> remove in comm-central. Along those lines, it looks like the nsIX509Cert
> constants VERIFIED_OK, NOT_VERIFIED_UNKNOWN, etc. will have to be dealt with
> here:
> https://dxr.mozilla.org/comm-central/rev/
> 752a2122c521c5115049f4fbb4229484a05b2c2c/mailnews/extensions/smime/content/
> msgCompSecurityInfo.js#24
> As far as I can tell, that function is only being used from line 204 of that
> file. The values passed to it come from the call to
> nsISMimeJSHelper.getRecipientCertsInfo on line 89. Looking at the
> implementation, those values appear to all just be 0:
> https://dxr.mozilla.org/comm-central/source/mailnews/extensions/smime/src/
> nsSMimeJSHelper.cpp#97 so this implementation can be simplified somewhat.

Thank you, David.

Magnus, should I file a new bug for this cleanup or do we this in this bug? My knowledge is too low to fix this.
Flags: needinfo?(mkmelin+mozilla)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Filed bug 1293378.
Flags: needinfo?(mkmelin+mozilla)
You need to log in before you can comment on or make changes to this bug.