1287836 - Download is "Failed" after reconnecting to a WiFi network that was lost.

Status: RESOLVED INVALID

(Core :: Networking, defect)

Description

[Alexandru Simonca [:asimonca], Release Desktop QA]

Issue uncovered on Windows 10 Pro Build 14390 running on MS Surface;

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0

Steps to reproduce:
1. Download a file.
2. Take the device outside the WiFi range until there is no more WiFi signal.
3. Take the device back and connect it to the network.

Expected results:
The download is resumed when the device is back in range.

Actual results:
The download is cancelled after connecting the device back to the network.

Note:
This is reproducible only on portable devices.

Comment 1

[:Paolo Amadini]

I think this may be caused by the fact that we don't detect this and we don't go to offline mode.

Comment 2

[:Paolo Amadini]

Or that we detect the change, but we try to connect too early, and the resume doesn't work.

Also worth checking if the link you used is actually resumable under normal conditions?

Comment 3

[Dragana Damjanovic [:dragana]]

Can you make a Http log:
https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/HTTP_logging

Comment 4

[Alexandru Simonca [:asimonca], Release Desktop QA]

Hello,
I have reproduced the issue again and I made sure that the link is resumable under normal conditions first. I used the same tablet (MS Surface 2) but with a newer build of Windows 10 x64 (build 14936.1000) and Firefox Beta 50.0b7 (id: 20161017130949). I have also attached an HTTP log file. Please let me know if I can be of further assistance.

Note: The log is too big to post directly to bugzilla so here is a link to it.
https://www.dropbox.com/s/qiyl5t8itg5zlh0/log.txt?dl=0

Comment 5

[Dragana Damjanovic [:dragana]]

(In reply to Alexandru Simonca, QA (:asimonca) from comment #4)
> Hello,
> I have reproduced the issue again and I made sure that the link is resumable
> under normal conditions first. I used the same tablet (MS Surface 2) but
> with a newer build of Windows 10 x64 (build 14936.1000) and Firefox Beta
> 50.0b7 (id: 20161017130949). I have also attached an HTTP log file. Please
> let me know if I can be of further assistance.
> 
> Note: The log is too big to post directly to bugzilla so here is a link to
> it.
> https://www.dropbox.com/s/qiyl5t8itg5zlh0/log.txt?dl=0

I need a bit of help to debug this. Can you explain what you did?
There are 3 request fro 1gb.zip. Each of them did not finish.

The first one got NS_ERROR_NET_RESET

The second:
2016-10-18 11:52:44.808000 UTC - [Socket Thread]: D/nsSocketTransport   calling PR_Read [count=28388]
2016-10-18 11:52:44.808000 UTC - [Socket Thread]: D/nsSocketTransport   PR_Read returned [n=0]
2016-10-18 11:52:44.808000 UTC - [Socket Thread]: V/nsHttp nsHttpConnection::OnSocketReadable 25ae8b82380 trans->ws rv=0 n=1460 socketin=80470002
2016-10-18 11:52:44.808000 UTC - [Socket Thread]: V/nsHttp nsHttpConnection::CloseTransaction[this=25ae8b82380 trans=25adfb8fc00 reason=80470002]
2016-10-18 11:52:44.808000 UTC - [Socket Thread]: D/nsHttp nsHttpTransaction::Close [this=25adfb8fc00 reason=0]
2016-10-18 11:52:44.808000 UTC - [Socket Thread]: D/nsHttp Partial transfer, incomplete HTTP response received: c-l underru

 "PR_Read returned [n=0]" means that a read on a socket return 0, which means that socket was closed by the remote peer.
Necko will not retry in this case.

The third one was just canceled by user.

Comment 6

[Alexandru Simonca [:asimonca], Release Desktop QA]

In both the first cases I took the tablet outside the WiFi range to lose signal and then came back to make it reconnect to the same network automatically and resume the download, which it did. After that it just said "Failed". In the third case I canceled the download intentionally.

Comment 7

[Dragana Damjanovic [:dragana]]

(In reply to Alexandru Simonca, QA (:asimonca) from comment #6)
> In both the first cases I took the tablet outside the WiFi range to lose
> signal and then came back to make it reconnect to the same network
> automatically and resume the download, which it did. After that it just said
> "Failed". In the third case I canceled the download intentionally.

From the log it looks like the server closed the connection. I do not see anything we did to close it.

May I ask you to try another server?

Comment 8

[Alexandru Simonca [:asimonca], Release Desktop QA]

Sure, I'll be back with the results by EOD.

Comment 9

[u408661]

Dragana, please re-triage/re-assign as appropriate once more data is available.

Comment 10

[Alexandru Simonca [:asimonca], Release Desktop QA]

Attachment: log.zip

Sorry for the late reply. 
I've tried reproducing the issue again using the same tablet and Nightly 52.0a1 (id: 20161024030205) and with the link "https://www.ubuntu.com/download/desktop/thank-you?version=16.04.1&architecture=amd64". I couldn't reproduce the issue anymore. I don't know if it was because the earlier download links weren't as reliable or if it was because I switched to Nightly.
I've made some more http logging but this time I wound up with four separate log.txt files. Don't know what went wrong there. I'll put a zip file with them here.

Comment 11

[Dragana Damjanovic [:dragana]]

so you cannot reproduce the issue?

From your log, the one where a download failed, I have seen that connection was closed by the server. Therefore I assume that this is not a firefox issue and I will close it.

Comment 12

[Alexandru Simonca [:asimonca], Release Desktop QA]

 Well, the first time I found the issue was over 3 months ago so maybe something happened in the meantime that fixed the issue. I'm ok with you closing this, since I couldn't reproduce it like the first time.