Closed
Bug 128784
Opened 23 years ago
Closed 23 years ago
Redundant use of DBNameToIDAndCheck in userprefs.cgi
Categories
(Bugzilla :: User Accounts, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: justdave, Assigned: myk)
Details
Attachments
(1 file)
|
752 bytes,
patch
|
gerv
:
review+
gerv
:
review+
|
Details | Diff | Splinter Review |
The new userprefs.cgi that was recently checked in contains the following code:
confirm_login();
GetVersionTable();
$userid = DBNameToIdAndCheck($::COOKIE{'Bugzilla_login'});
The last of these three lines is unnecessary. confirm_login, two lines above,
already does this. (Including setting the value of $::userid).
We shouldn't need to have $userid declared as a local variable here.
|
Assignee | |
Comment 1•23 years ago
|
||
|
||
Comment 2•23 years ago
|
||
Comment on attachment 72442 [details] [diff] [review]
patch v1: fixes problem
That'll do :-) rx2=gerv.
Gerv
Attachment #72442 -
Flags: review+
|
|
Assignee | |
Comment 3•23 years ago
|
||
Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v <-- userprefs.cgi
new revision: 1.30; previous revision: 1.29
done
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 4•23 years ago
|
||
fixing incorrect milestones on fixed bugs.
Target Milestone: --- → Bugzilla 2.16
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•