Closed Bug 128784 Opened 21 years ago Closed 21 years ago

Redundant use of DBNameToIDAndCheck in userprefs.cgi

Categories

(Bugzilla :: User Accounts, defect)

2.15
PowerPC
Mac System 9.x
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: justdave, Assigned: myk)

Details

Attachments

(1 file)

The new userprefs.cgi that was recently checked in contains the following code:

confirm_login();
    
GetVersionTable();

$userid = DBNameToIdAndCheck($::COOKIE{'Bugzilla_login'});

The last of these three lines is unnecessary.  confirm_login, two lines above,
already does this.  (Including setting the value of $::userid).

We shouldn't need to have $userid declared as a local variable here.
Comment on attachment 72442 [details] [diff] [review]
patch v1: fixes problem

That'll do :-) rx2=gerv.

Gerv
Attachment #72442 - Flags: review+
Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.30; previous revision: 1.29
done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
fixing incorrect milestones on fixed bugs.
Target Milestone: --- → Bugzilla 2.16
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.