128784 - Redundant use of DBNameToIDAndCheck in userprefs.cgi

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Dave Miller [:justdave]]

The new userprefs.cgi that was recently checked in contains the following code:

confirm_login();
    
GetVersionTable();

$userid = DBNameToIdAndCheck($::COOKIE{'Bugzilla_login'});

The last of these three lines is unnecessary.  confirm_login, two lines above,
already does this.  (Including setting the value of $::userid).

We shouldn't need to have $userid declared as a local variable here.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 72442 [details] [diff] [review]
patch v1: fixes problem

That'll do :-) rx2=gerv.

Gerv

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.30; previous revision: 1.29
done

Comment 4

[Dave Miller [:justdave]]

fixing incorrect milestones on fixed bugs.