1287843 - Active download is paused without warning if disconnected from internet connection

Status: RESOLVED WONTFIX

(Firefox :: Downloads Panel, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- latest Nightly 50.0a1 (2016-07-19)
- latest Aurora 49.0a2 (2016-07-19)
- 48.0b9 build 1 (20160718142219)
- 47.0.1 build 1 (20160623154057)

[Affected platforms]:
- Mac OS X 10.9.5
- (intermittently) Windows 7 x86
- (intermittently) Windows 10 x64

[Steps to reproduce]:
1. Launch Firefox
2. Go to http://www.ubuntu.com/download/desktop/thank-you?country=RO&version=14.04.4&architecture=amd64 and start downloading the large file
3. Disconnect your internet connection
- inspect the Downloads button and Downloads Panel state
4. Enable your internet connection
- inspect the Downloads button and Downloads Panel state

[Expected result]:
- [step 3] The active download is paused and downloads panel displays a warning in order to inform the user that the download process is affected by the internet connection state (and therefore the download process is paused)
- [step 4] The paused download is resumed and downloads panel informs the user that the internet connection has been enabled (and therefore the download process is resumed from where it left off)


[Actual result]:
-[step 3] The active download is paused without warning
-[step 4] The paused download is resumed without any notification

[Regression range]:
- I will investigate this as soon as possible

[Additional notes]:
- I couldn't reproduce this issue on Ubuntu platform

Comment 1

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Back with more information: 
- this issue started reproducing with Nightly 2015-06-22 build
*Last good revision: a38c23ccca0a (2015-06-21)
*First bad revision: be81b8d6fae9 (2015-06-22)
*Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a38c23ccca0a&tochange=be81b8d6fae9

- going back in time, starting with Nightly 2013-08-22 build, when user disconnects the internet connection, the download process fails without a warning
*Last good revision: b2486721572e (2013-08-21)
*First bad revision: 2ab07dec6404 (2013-08-22)
*Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b2486721572e&tochange=2ab07dec6404

- till Nightly 2013-08-21 build, when user disconnects the internet connection, the download process fails, but a warning message is displayed 

In my opinion, in order to avoid user confusion cases, the download warning message should be reapplied

Comment 2

[Justin Dolske [:Dolske]]

Is the ER in comment 0 what's actually supposed to happen here? (More generally, do we really try to pause and resume downloads when the connection is interrupted, or just treat it as a failure?)

Comment 3

[:Paolo Amadini]

Iulia, it's not clear to me what you mean by warning message. If you're talking about a modal dialog when the download is paused, I'm pretty sure we don't want it because in general we're moving away from this UI model.

If you mean the download changing its state to "paused" in the panel, with the progress bar in the toolbar becoming yellow, we have code that tries do just that, but it's only effective when we detect a change in the system network state. If we don't detect this change, the download progress just stops, than resumes as soon as possible - this is just how the TCP/IP protocol stack works.

Comment 4

[:Paolo Amadini]

Closing per comment 3, feel free to reopen if there is something I missed.