1287854 - ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:63:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACSt

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-tier=1&filter-tier=2&filter-tier=3&filter-searchStr=b2g&selectedJob=4404870

Comment 1

[:gerard-majax]

Likely because of bug 1213517 :)

Comment 2

[:gerard-majax]

../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:63:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&)' marked override, but does not override
../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:67:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Deallocate()' marked override, but does not override
../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:71:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Restart(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' marked override, but does not override
../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:117:10: error: 'size_t mozilla::MediaEngineGonkVideoSource::NumCapabilities()' marked override, but does not override
../../../../../workspace/gecko/dom/media/webrtc/MediaEngine.h:131:20: error: 'virtual nsresult mozilla::MediaEngineSource::Deallocate(mozilla::MediaEngineSource::BaseAllocationHandle*)' was hidden [-Werror=overloaded-virtual]
../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:67:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Deallocate()' [-Werror=overloaded-virtual]
../../../../../workspace/gecko/dom/media/webrtc/MediaEngine.h:152:20: error: 'virtual nsresult mozilla::MediaEngineSource::Restart(mozilla::MediaEngineSource::BaseAllocationHandle*, const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const char**)' was hidden [-Werror=overloaded-virtual]
../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:71:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Restart(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' [-Werror=overloaded-virtual]
../../../../../workspace/gecko/dom/media/webrtc/MediaEngine.h:189:20: error: 'virtual nsresult mozilla::MediaEngineSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&, mozilla::MediaEngineSource::BaseAllocationHandle**, const char**)' was hidden [-Werror=overloaded-virtual]
../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:63:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&)' [-Werror=overloaded-virtual]
../../../../../workspace/gecko/dom/media/webrtc/MediaEngineCameraVideoSource.h:88:18: error: 'virtual size_t mozilla::MediaEngineCameraVideoSource::NumCapabilities() const' was hidden [-Werror=overloaded-virtual]
../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:117:10: error: by 'size_t mozilla::MediaEngineGonkVideoSource::NumCapabilities()' [-Werror=overloaded-virtual]
../../../../../workspace/gecko/dom/media/webrtc/MediaEngineWebRTC.cpp:175:49: error: invalid new-expression of abstract class type 'mozilla::MediaEngineGonkVideoSource'
make[6]: *** [MediaEngineWebRTC.o] Error 1
make[6]: *** Waiting for unfinished jobs....
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:63:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&)' marked override, but does not override
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:67:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Deallocate()' marked override, but does not override
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:71:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Restart(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' marked override, but does not override
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:117:10: error: 'size_t mozilla::MediaEngineGonkVideoSource::NumCapabilities()' marked override, but does not override
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngine.h:131:20: error: 'virtual nsresult mozilla::MediaEngineSource::Deallocate(mozilla::MediaEngineSource::BaseAllocationHandle*)' was hidden [-Werror=overloaded-virtual]
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:67:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Deallocate()' [-Werror=overloaded-virtual]
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngine.h:152:20: error: 'virtual nsresult mozilla::MediaEngineSource::Restart(mozilla::MediaEngineSource::BaseAllocationHandle*, const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const char**)' was hidden [-Werror=overloaded-virtual]
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:71:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Restart(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' [-Werror=overloaded-virtual]
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngine.h:189:20: error: 'virtual nsresult mozilla::MediaEngineSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&, mozilla::MediaEngineSource::BaseAllocationHandle**, const char**)' was hidden [-Werror=overloaded-virtual]
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:63:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&)' [-Werror=overloaded-virtual]
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineCameraVideoSource.cpp:42:1: error: 'virtual size_t mozilla::MediaEngineCameraVideoSource::NumCapabilities() const' was hidden [-Werror=overloaded-virtual]
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:117:10: error: by 'size_t mozilla::MediaEngineGonkVideoSource::NumCapabilities()' [-Werror=overloaded-virtual]
/home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:159:53: error: no matching function for call to 'mozilla::MediaEngineGonkVideoSource::ChooseCapability(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)'
make[6]: *** [Unified_cpp_dom_media_webrtc0.o] Error 1
make[5]: *** [dom/media/webrtc/target] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [realbuild] Error 2
make[1]: *** [build] Error 2
make: *** [out/target/product/aries/obj/DATA/gecko_intermediates/gecko] Error 2

Comment 3

[:gerard-majax]

Attachment: Bug 1287854 - Fix MediaEngineGonk build

Review commit: https://reviewboard.mozilla.org/r/65272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65272/

Comment 4

[:gerard-majax]

This will require more work:
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp: In member function 'virtual nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&, mozilla::MediaEngineSource::BaseAllocationHandle**, const char**)':
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:161:53: error: no matching function for call to 'mozilla::MediaEngineGonkVideoSource::ChooseCapability(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)'
     ChooseCapability(aConstraints, aPrefs, aDeviceId);
                                                     ^
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:161:53: note: candidate is:
In file included from Unified_cpp_dom_media_webrtc0.cpp:11:0:
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineCameraVideoSource.cpp:207:1: note: virtual bool mozilla::MediaEngineCameraVideoSource::ChooseCapability(const mozilla::NormalizedConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)
 MediaEngineCameraVideoSource::ChooseCapability(
 ^
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineCameraVideoSource.cpp:207:1: note:   no known conversion for argument 1 from 'const mozilla::dom::MediaTrackConstraints' to 'const mozilla::NormalizedConstraints&'
In file included from Unified_cpp_dom_media_webrtc0.cpp:29:0:
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp: In member function 'virtual void mozilla::MediaEngineGonkVideoSource::Shutdown()':
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:392:16: error: no matching function for call to 'mozilla::MediaEngineGonkVideoSource::Deallocate()'
     Deallocate();
                ^
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:392:16: note: candidate is:
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:175:1: note: virtual nsresult mozilla::MediaEngineGonkVideoSource::Deallocate(mozilla::MediaEngineSource::BaseAllocationHandle*)
 MediaEngineGonkVideoSource::Deallocate(BaseAllocationHandle* aHandle)
 ^
/home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:175:1: note:   candidate expects 1 argument, 0 provided

Comment 5

[:gerard-majax]

Comment on attachment 8772474 [details]
Bug 1287854 - Fix MediaEngineGonk build

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65272/diff/1-2/

Comment 6

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=abe3f0322e63

Comment 7

[:gerard-majax]

I'll probably use that bug just to fix build time and file a follow up to perform the proper upgrade of that code.

Comment 8

[:gerard-majax]

Comment on attachment 8772474 [details]
Bug 1287854 - Fix MediaEngineGonk build

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65272/diff/2-3/

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8772474 [details]
Bug 1287854 - Fix MediaEngineGonk build

https://reviewboard.mozilla.org/r/65272/#review62868

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91056939fa77
Fix MediaEngineGonk build r=padenot

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/91056939fa77