Closed Bug 1287924 Opened 4 years ago Closed 4 years ago
Find a better solution for conditionally including moz
58 bytes, text/x-review-board-request
Currently we have quite a few moz.configure files being conditionally included by the root moz.configure, based on whether we're building with --disable-compile-environment. We should templatize this to avoid duplication or find another way to handle the proliferation.
Following a recent pattern, we could have a include_when() template.
Review commit: https://reviewboard.mozilla.org/r/66978/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/66978/
Attachment #8774541 - Flags: review?(mh+mozilla)
Comment on attachment 8774541 [details] Bug 1287924 - Add a template for conditionally including moz.configure files. https://reviewboard.mozilla.org/r/66978/#review63936 You could also change android_ndk_include ::: moz.configure:97 (Diff revision 1) > > add_old_configure_assignment('MOZ_DEBUG', > depends('--enable-debug')(lambda v: bool(v))) > > -@depends('--disable-compile-environment', '--help') > -def toolchain_include(compile_env, help): > +include_when('build/moz.configure/toolchain.configure', > + '--enable-compile-environment') An explicit when= might make it a little clearer.
Attachment #8774541 - Flags: review?(mh+mozilla) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/83db605b772e Add a template for conditionally including moz.configure files. r=glandium
4 years ago
Assignee: nobody → cmanchester
You need to log in before you can comment on or make changes to this bug.