Closed
Bug 1287937
Opened 9 years ago
Closed 9 years ago
Remove obsolete mac-specific code from modules/libmar/verify/MacVerifyCrypto.cpp and mozglue/misc/StackWalk.cpp.
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: stefanh, Assigned: stefanh)
Details
Attachments
(1 file, 1 obsolete file)
11.62 KB,
patch
|
spohl
:
review+
|
Details | Diff | Splinter Review |
This is the changes we talked about for a while ago.
A 15 minutes old try push is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78ee26be1fb6
Attachment #8772579 -
Flags: review?(spohl.mozilla.bugs)
Comment 1•9 years ago
|
||
Comment on attachment 8772579 [details] [diff] [review]
crypto-stackwalk.diff
Review of attachment 8772579 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great. We should remove everything pertaining to CSSM while we're here. I'd like to have another look at the next patch, so clearing r? flag for now. Thanks!
::: modules/libmar/verify/MacVerifyCrypto.cpp
@@ -93,1 @@
> static bool sCssmInitialized = false;
Please remove this and everything below that pertains to CSSM. You have removed everything that made use of this. CSSM was needed for 10.6 only.
@@ -409,5 @@
> {
> if (!aPublicKey || !*aPublicKey) {
> return;
> }
> - if (!OnLionOrLater() && sCspHandle != CSSM_INVALID_HANDLE) {
This entire block can be removed, since this only used to be true when we weren't on Lion or later.
Attachment #8772579 -
Flags: review?(spohl.mozilla.bugs)
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Stephen A Pohl [:spohl] from comment #1)
> ::: modules/libmar/verify/MacVerifyCrypto.cpp
> @@ -93,1 @@
> > static bool sCssmInitialized = false;
>
> Please remove this and everything below that pertains to CSSM. You have
> removed everything that made use of this. CSSM was needed for 10.6 only.
Done.
>
> @@ -409,5 @@
> > {
> > if (!aPublicKey || !*aPublicKey) {
> > return;
> > }
> > - if (!OnLionOrLater() && sCspHandle != CSSM_INVALID_HANDLE) {
>
> This entire block can be removed, since this only used to be true when we
> weren't on Lion or later.
Oops, that was embarrasing... fixed.
Attachment #8772579 -
Attachment is obsolete: true
Attachment #8773437 -
Flags: review?(spohl.mozilla.bugs)
Comment 3•9 years ago
|
||
Comment on attachment 8773437 [details] [diff] [review]
New version
Review of attachment 8773437 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks! Please run this through try one last time before landing.
Attachment #8773437 -
Flags: review?(spohl.mozilla.bugs) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks Stephen!
Let's see how https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffb6c0a8341a looks.
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0353590d4e05
Remove obsolete mac-specific code from modules/libmar/verify/MacVerifyCrypto.cpp and mozglue/misc/StackWalk.cpp. r=spohl.
Comment 6•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•