Closed Bug 1287937 Opened 9 years ago Closed 9 years ago

Remove obsolete mac-specific code from modules/libmar/verify/MacVerifyCrypto.cpp and mozglue/misc/StackWalk.cpp.

Categories

(Toolkit :: Application Update, defect)

Unspecified
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: stefanh, Assigned: stefanh)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch crypto-stackwalk.diff (obsolete) — Splinter Review
This is the changes we talked about for a while ago. A 15 minutes old try push is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78ee26be1fb6
Attachment #8772579 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8772579 [details] [diff] [review] crypto-stackwalk.diff Review of attachment 8772579 [details] [diff] [review]: ----------------------------------------------------------------- Looks great. We should remove everything pertaining to CSSM while we're here. I'd like to have another look at the next patch, so clearing r? flag for now. Thanks! ::: modules/libmar/verify/MacVerifyCrypto.cpp @@ -93,1 @@ > static bool sCssmInitialized = false; Please remove this and everything below that pertains to CSSM. You have removed everything that made use of this. CSSM was needed for 10.6 only. @@ -409,5 @@ > { > if (!aPublicKey || !*aPublicKey) { > return; > } > - if (!OnLionOrLater() && sCspHandle != CSSM_INVALID_HANDLE) { This entire block can be removed, since this only used to be true when we weren't on Lion or later.
Attachment #8772579 - Flags: review?(spohl.mozilla.bugs)
Attached patch New versionSplinter Review
(In reply to Stephen A Pohl [:spohl] from comment #1) > ::: modules/libmar/verify/MacVerifyCrypto.cpp > @@ -93,1 @@ > > static bool sCssmInitialized = false; > > Please remove this and everything below that pertains to CSSM. You have > removed everything that made use of this. CSSM was needed for 10.6 only. Done. > > @@ -409,5 @@ > > { > > if (!aPublicKey || !*aPublicKey) { > > return; > > } > > - if (!OnLionOrLater() && sCspHandle != CSSM_INVALID_HANDLE) { > > This entire block can be removed, since this only used to be true when we > weren't on Lion or later. Oops, that was embarrasing... fixed.
Attachment #8772579 - Attachment is obsolete: true
Attachment #8773437 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8773437 [details] [diff] [review] New version Review of attachment 8773437 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Please run this through try one last time before landing.
Attachment #8773437 - Flags: review?(spohl.mozilla.bugs) → review+
Pushed by stefanh@inbox.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0353590d4e05 Remove obsolete mac-specific code from modules/libmar/verify/MacVerifyCrypto.cpp and mozglue/misc/StackWalk.cpp. r=spohl.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: