1287980 - Combined toolbar buttons get huge after Restore Defaults -> Undo

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Move the Cut/Copy/Paste buttons to the toolbar
Enter customization mode
Click Restore Defaults
Click Undo

ER:
The cut/copy/paste buttons should be normal size.

AR:
The buttons are supersized.

This is because the Undo operation puts the buttons back in the toolbar but it doesn't add the .toolbarbutton-1 class to the nested <xul:toolbarbutton> within the <xul:toolbaritem>.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I ran mozregression and this has been broken since Undo was implemented,
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=802d87c77e76&tochange=a62bde1d6efe

Comment 2

[:Gijs (out for now; he/him)]

Attachment: Bug 1287980 - fix combined toolbar button styling after undo reset,

Review commit: https://reviewboard.mozilla.org/r/65552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65552/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8772818 [details]
Bug 1287980 - fix combined toolbar button styling after undo reset,

https://reviewboard.mozilla.org/r/65552/#review63310

::: browser/base/content/browser.xul
(Diff revision 1)
> -    <!--
> -           CAVEAT EMPTOR
> -           Should you need to add items to the toolbar here, make sure to also add them
> -           to the default placements of buttons in CustomizableUI.jsm, so the
> -           customization code doesn't get confused.
> -      -->

Why don't we want this warning anymore?

Comment 4

[:Gijs (out for now; he/him)]

https://reviewboard.mozilla.org/r/65552/#review63310

> Why don't we want this warning anymore?

It was originally added to explain the duplication between `defaultset` and CUI.jsm. Defaultset is gone now, and people are pretty used to adding things to/via CUI.jsm these days, so I don't think it's useful to keep it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b35d43491f5
fix combined toolbar button styling after undo reset, r=jaws

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b35d43491f5

Comment 7

[Md. Majedul islam]

I have reproduced this bug with Firefox nightly 50.0a1 (2016-07-19) on Windows 10, 64 Bit.

The bug's fix is now verified on latest nightly 51.0a1.

Build ID 	20160824030337
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160824]

Comment 8

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 50.0a1 (2016-07-19) (Build ID: 20160719030224) on Linux, 64 bit!

The bug's fix is now verified on Latest Nightly 51.0a1!

Build ID: 20160824030337
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
OS: Ubuntu 16.04, Linux 4.4.0-34-generic

As this bug’s fix is also verified on Windows 10, 64 bit (comment 7), I am marking this as verified!

Comment 9

[Azmina]

I have reproduced this bug with Nightly 50.0a1 (2016-07-19) on Windows 8.1 (64 bit).

This bug's fix is verified on Latest Aurora 50.0a2.
Build ID : 20160826004001
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0

[testday-20160826]