128801 - downloading dialog has "-1%" in titlebar

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Henrik Gemal]

go to:
http://bugzilla.mozilla.org/show_bug.cgi?id=119690
2) right click on the "Additional comments" attachment link and say "Save Link
As..."
select save to disk and watch the download dialog.

"-1% of attachment.cgi.html Saved"

20020303

Comment 1

[Boris Zbarsky [:bzbarsky]]

to file handling...

Comment 2

[sairuh (rarely reading bugmail)]

also see this on mac 10.1.3...and it's been there at least since the
2002.02.28.0x builds... (n/a to linux since we don't use the titlebar there to
display download progress.)

Comment 3

[Peter Trudelle]

->future.  

Comment 4

[John Levon]

It is applicable to Linux, because I've just seen it :)

Comment 5

[Cedric Berger]

I got that twice today using RC1
Last time:
http://www.javalobby.org/members/codenotes/CodeNotes_for_J2EE.pdf
IT'S REALLY UGLY AND SHOULD BE FIXED for 1.0

Comment 6

[Lawrence Hudson]

Seen with RC3 running on Win2k when downloading
http://www.palmos.com/alliance/resources.cgi/devseed/Palm_OS_5_Simulator_Dbg_dr12.zip
(requires authentication).

It is may be relevant that the 'Status:' field in the download dialog shows
total file size as 0 KB.

Comment 7

[Adam Sampson]

I always see this for HTTP downloads (with 1.0-rc3 on Linux); I'm behind an
Apache 2 HTTP proxy, which for some reason neglects to pass on file sizes for
anything it's proxying, so Mozilla never knows how big the file it's downloading is.

Comment 8

[moz]

I have windows 2000, 1.0 final release and I see it too in
http://genghis.winamp.com/~steve/archive/?display=mozilla%2FMozilla%20Icon%20Source%20files.zip
and several other places. 

At least, Mozilla can detect that -1% situation and say only "Downloading file.zip" instead of "-1% of file.zip saved" which is very unprofessional and makes Mozilla look like a buggy browser.

Comment 9

[moz]

Damned! I've tried it also with Internet Exploter, it detects the situation and it does not say the total lenght to avoid the problem.

Comment 10

[Aaron Kaluszka]

Attachment: Proposed fix

Comment 11

[Aaron Kaluszka]

FYI: this patch fixes this bug, but does not fix the download manager problem
(bug 152050).

Comment 12

[Aaron Kaluszka]

Bill, can you review this?

Comment 13

[Bill Law]

I think there needs to be 2 distinct strings: "Saving #1" and "Opening #1" (so
that the title doesn't say "Saving" when the user has chosen to open with an
application).

Otherwise, things look OK.  Add the additional string and the code to support it
and I'll r=.

Comment 14

[Aaron Kaluszka]

Attachment: Patch with Bill's suggestions

Comment 15

[Bill Law]

Comment on attachment 88176 [details] [diff] [review]
Patch with Bill's suggestions

r=law

Comment 16

[Aaron Kaluszka]

Blake, can I get an sr?

Comment 17

[Bill Mason]

*** Bug 146721 has been marked as a duplicate of this bug. ***

Comment 18

[Brian Ryner (not reading)]

Comment on attachment 88176 [details] [diff] [review]
Patch with Bill's suggestions

sr=bryner

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 88176 [details] [diff] [review]
Patch with Bill's suggestions

a=asa (on behalf of drivers) for checkin to 1.1

Comment 20

[Aaron Kaluszka]

Great, can somebody check this in?  I don't have CVS write privs.

Comment 21

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in to trunk for Aaron.

Comment 22

[Aaron Kaluszka]

verified on trunk