1288194 - [e10s] Some SVG images do not print

Status: VERIFIED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

+++ This bug was initially created as a clone of Bug #1287512 +++

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160623154057

Steps to reproduce:

1. Open attachment 8772049 [details] of Bug 1287512
2. Print with "Microsoft XPS Document Writer"
   and Save as XPS document like test.xps

Actual results:
With HWA on
SVG image prints anything
Pure Image print "gray rectangle"

With HWA off
SVG image prints properly("light-blue filled circle").
Pure Image print "light-blue filled circle" and "gray rectangle" background

Expected results:
Both types should print "light-blue filled circle"

Comment 1

[Alice0775 White]

This seems affected to nightly channel only.
Because, it was fixed when it merged to [2]Aurora49.0a2 from [1]Nightly49.0a1.

[1]
https://hg.mozilla.org/mozilla-central/rev/0a3b6e2df6567d845f31c000c68dd67816c6153d
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 ID:20160606025732

[2]
https://hg.mozilla.org/releases/mozilla-aurora/rev/cea65ca3d0bdd8325dc556f6bfde6277fc83fe6e
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 ID:20160606144834

Comment 2

[Alice0775 White]

So, seems process sandboxing problem.

Comment 3

[Alice0775 White]

It works as expected if set the following preferences.
user_pref("print.print_via_parent", false);
user_pref("security.sandbox.content.level", 0);

Comment 4

[Marcia Knous [:marcia]]

Tracking 50+ for this printing regression.

Comment 5

[Andrew Overholt [:overholt]]

Are we letting this aspect of sandboxing ride in 50?

Comment 6

[Bob Owen (:bobowen)]

(In reply to Andrew Overholt [:overholt] from comment #5)
> Are we letting this aspect of sandboxing ride in 50?

Yes, the low integrity sandbox settings will (hopefully :-) ) be riding in 50.
This is actually not a problem with the sandbox directly, but with the print via parent, which we need to be able to turn on sandboxing.

Something must be going wrong with the recording or playback of the DrawTarget calls.
I'll look into it.

Comment 7

[Bob Owen (:bobowen)]

The missing circles is down to this:
https://hg.mozilla.org/mozilla-central/file/5df2781a3b0c/gfx/2d/PathRecording.h#l66

Where we are just throwing away calls to PathBuilderRecording::Arc

Looks like that is pretty easy to fix.

The grey rectangle appears to be something else that I haven't tracked down yet.

Comment 8

[Bob Owen (:bobowen)]

... and the grey rectangle is down to me botching the recording of DrawTargetRecording::PushLayer, possibly an IntelliSense blunder.

Comment 9

[Bob Owen (:bobowen)]

Attachment: Bug 1288194 Part 1: Implement PathBuilderRecording::Arc correctly.

Review commit: https://reviewboard.mozilla.org/r/70040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70040/

Comment 10

[Bob Owen (:bobowen)]

Attachment: Bug 1288194 Part 2: Fix incorrectly recorded argument in DrawTargetRecording::PushLayer.

Review commit: https://reviewboard.mozilla.org/r/70042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70042/

Comment 11

[Bas Schouten (:bas.schouten)]

Comment on attachment 8778966 [details]
Bug 1288194 Part 1: Implement PathBuilderRecording::Arc correctly.

https://reviewboard.mozilla.org/r/70040/#review67656

Comment 12

[Bas Schouten (:bas.schouten)]

Comment on attachment 8778967 [details]
Bug 1288194 Part 2: Fix incorrectly recorded argument in DrawTargetRecording::PushLayer.

https://reviewboard.mozilla.org/r/70042/#review67658

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0c1998f35d2
Part 1: Implement PathBuilderRecording::Arc correctly. r=bas
https://hg.mozilla.org/integration/autoland/rev/a31335a3173a
Part 2: Fix incorrectly recorded argument in DrawTargetRecording::PushLayer. r=bas

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a0c1998f35d2
https://hg.mozilla.org/mozilla-central/rev/a31335a3173a

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Bob, could you fill the uplift request to 50 to fix this new regression? Thanks

Comment 16

[Bob Owen (:bobowen)]

Comment on attachment 8778966 [details]
Bug 1288194 Part 1: Implement PathBuilderRecording::Arc correctly.

(In reply to Sylvestre Ledru [:sylvestre] from comment #15)
> Bob, could you fill the uplift request to 50 to fix this new regression?
> Thanks

Thanks for reminding me.

Approval Request Comment
[Feature/regressing bug #]:
Introduced by the use of Moz2D recording for printing via the parent.

[User impact if declined]:
Certain pages won't render properly when printing.

[Describe test coverage new/current, TreeHerder]:
Manual testing.
Good candidate for QE verification.

[Risks and why]:
Low - both patches are simple and localised.

[String/UUID change made/needed]:
None.

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Alice0775 White, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8778966 [details]
Bug 1288194 Part 1: Implement PathBuilderRecording::Arc correctly.

Fix for a recent regression, stabilized on nightly for ~2 weeks, Aurora50+

Comment 19

[Alice0775 White]

(In reply to Ritu Kothari (:ritu) from comment #17)
> Hi Alice0775 White, could you please verify this issue is fixed as expected
> on a latest Nightly build? Thanks!

The problem is fixed on Nightly51.0a1 23-Aug-2016 build with/without HWA. 
Thanks!

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/45e8335e629e
https://hg.mozilla.org/releases/mozilla-aurora/rev/9d5109af8c1d

Comment 21

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Alice0775 White from comment #19)
> (In reply to Ritu Kothari (:ritu) from comment #17)
> > Hi Alice0775 White, could you please verify this issue is fixed as expected
> > on a latest Nightly build? Thanks!
> 
> The problem is fixed on Nightly51.0a1 23-Aug-2016 build with/without HWA. 
> Thanks!

Fantastic! Thank you for the verification.

Comment 22

[Carmen]

I reproduced the issue using an old Nightly 50.0a1 (2016-07-14) build, on Windows 10 Pro x64, with both enabled/disabled HWA.

The fix is now verified on Firefox Beta 50.0b4 on same platform, with both enabled/disabled HWA.

Comment 23

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Thank you, Carmen!