1288224 - Marionette imports requests but doesn't list it in requirements

Status: RESOLVED INVALID

(Remote Protocol :: Marionette, defect)

Description

[Andrew Halberstadt [:ahal]]

Marionette imports requests here:
https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette/runner/mixins/browsermob-proxy-py/browsermobproxy/client.py#1

But this dependency isn't listed anywhere that I can tell. As a result, I'm getting an 'ImportError requests' when trying to do 'import marionette' in a taskcluster interactive worker.

I don't really know what browsermob-proxy is, but I don't think I'm using it. So maybe the requests import can simply be deferred until it is actually needed. Alternatively I could make sure the worker has requests installed, but in this case 'requests' should at least get added to the requirements.txt.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's in here:

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette/runner/mixins/browsermob-proxy-py/setup.py

browsermob-proxy is its own python package.

Comment 2

[Andrew Halberstadt [:ahal]]

Ah sorry, I didn't realize it was a separate package. Just tested and 'pip install marionette-client' does indeed also install requests. I still have a problem to solve, but looks like it's not related to marionette.