Marionette imports requests but doesn't list it in requirements

RESOLVED INVALID

Status

Testing
Marionette
RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: ahal, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
Marionette imports requests here:
https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette/runner/mixins/browsermob-proxy-py/browsermobproxy/client.py#1

But this dependency isn't listed anywhere that I can tell. As a result, I'm getting an 'ImportError requests' when trying to do 'import marionette' in a taskcluster interactive worker.

I don't really know what browsermob-proxy is, but I don't think I'm using it. So maybe the requests import can simply be deferred until it is actually needed. Alternatively I could make sure the worker has requests installed, but in this case 'requests' should at least get added to the requirements.txt.
(Reporter)

Comment 2

2 years ago
Ah sorry, I didn't realize it was a separate package. Just tested and 'pip install marionette-client' does indeed also install requests. I still have a problem to solve, but looks like it's not related to marionette.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.