1288263 - If chrome.tabs.detectLanguage can't detect the language, Firefox reports "un" while Chrome reports "und"

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[Will Bamberg [:wbamberg]]

Attachment: detect-lang-zip.zip

chrome.tabs.detectLanguage is supposed to detect the language of the content in a tab, and pass the language code into a callback.

According to the docs[1], if the language can't be detected, "und" should be passed to the callback (it seems that "und" is actually a special value for "Undetermined"[2]).

Firefox passes "un" in this situation.

I've attached a WebExtension you can use to verify this.

[1] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/detectLanguage
[2] https://www.loc.gov/standards/iso639-2/php/code_list.php

Comment 1

[Tomislav Jovanovic :zombie]

It looks this is just a simple nomenclature mismatch: "un" was an non-official two-letter language code, that only later got standardized as "und" three-letter ISO 639-2 [1] code, which Chrome responds with, even if they use "un" internally [2], just like we do [3].

A simple replace seems enough for compatibility.


[1] https://en.wikipedia.org/wiki/List_of_ISO_639-2_codes
[2] https://src.chromium.org/viewvc/chrome/trunk/src/third_party/cld/languages/internal/languages.cc
[3] http://searchfox.org/mozilla-central/source/browser/components/translation/LanguageDetector.jsm#134

Comment 2

[Tomislav Jovanovic :zombie]

Attachment: bug 1288263 - tabs.detectLanguage() returns "und" for undetermined,

Review commit: https://reviewboard.mozilla.org/r/78034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78034/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8790044 [details]
bug 1288263 - tabs.detectLanguage() returns "und" for undetermined,

https://reviewboard.mozilla.org/r/78034/#review76482

This looks good, but we should probably do the same thing for i18n.detectLanguage.

Comment 4

[Tomislav Jovanovic :zombie]

Comment on attachment 8790044 [details]
bug 1288263 - tabs.detectLanguage() returns "und" for undetermined,

https://reviewboard.mozilla.org/r/78034/#review76482

`i18n.detectLanguage` never returns "un".  it indicates weather the detection `isReliable`, and the array of `languages` found, which is simply empty in the case where `tabs.detectLanguage` would return "und".

Comment 5

[Tomislav Jovanovic :zombie]

Comment on attachment 8790044 [details]
bug 1288263 - tabs.detectLanguage() returns "und" for undetermined,

https://reviewboard.mozilla.org/r/78034/#review76482

http://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionUtils.jsm#1421

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8790044 [details]
bug 1288263 - tabs.detectLanguage() returns "und" for undetermined,

https://reviewboard.mozilla.org/r/78034/#review76680

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4e5156020e8
tabs.detectLanguage() returns "und" for undetermined, r=kmag

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e4e5156020e8

Comment 9

[Amy Tsay [:amyt]]

Thanks for the fix--I've added it here: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#September_2016