Closed Bug 1288279 Opened 8 years ago Closed 8 years ago

WebExt contextId must be globally unique, even with multiple processes

Categories

(WebExtensions :: Untriaged, defect)

Product:
WebExtensions
Component:
Untriaged
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox50 affected)

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox50 --- affected

People

(Reporter: robwu, Assigned: robwu)

References

(Blocks 1 open bug)

Details

(Whiteboard: triaged) 

contextId is currently calculated by the child process based on a local variable. This ID is used in several places, including the ChildAPIManager that shares the ID with the ParentAPIManager [2], who in turn uses the ID to maintain a global mapping to proxied contexts [3]. This will break if there is >1 content process.

[1] http://searchfox.org/mozilla-central/rev/868b17897f7a7fcd7f6f67fd8185a7370db46604/toolkit/components/extensions/ExtensionUtils.jsm#1247-1252
[2] http://searchfox.org/mozilla-central/rev/65bed54efcce67cf04a890f7fe253ccdfa6befdc/toolkit/components/extensions/Extension.jsm#408
Whiteboard: triaged
https://reviewboard.mozilla.org/r/70810/
Status: NEW → ASSIGNED
Depends on: 1287626
https://hg.mozilla.org/mozilla-central/rev/a327a15f5d55
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.