Closed Bug 1288358 Opened 7 years ago Closed 7 years ago

Ruleview editors tooltips should have more padding around content

Categories

(DevTools :: Inspector: Rules, defect, P1)

Product:
DevTools
Component:
Inspector: Rules
Type:
defect

Tracking

(firefox50 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 50
Iteration:
50.4 - Aug 1
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

(Whiteboard: [reserve-html])

Attachments

(1 file)

Bug 1288358 - restore padding around spectrum widget in colorpicker tooltip;
58 bytes, text/x-review-board-request
pbro
: review+
Details 
Regression from Bug 1267414. Arrow style XUL tooltips used to force a padding: 4px on the tooltip content.

The HTMLTooltip no longer forces this, but as a result some ruleview tooltips look too tight/have overflow issues.

The impacted tooltips are:
- colorpicker
- cubic-bezier
- filter
Assignee: nobody → jdescottes
Blocks: 1267414
Status: NEW → ASSIGNED
Flags: qe-verify-
Whiteboard: [devtools-html] [triage]
See Also: → 1286128
Comment on attachment 8773211 [details]
Bug 1288358 - restore padding around spectrum widget in colorpicker tooltip;

https://reviewboard.mozilla.org/r/65932/#review62856

Changes look good, thanks !
Attachment #8773211 - Flags: review?(pbrosset) → review+
Blocks: devtools-html-1
Iteration: --- → 50.4 - Aug 1
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [reserve-html]
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/e5ebff5eb655
restore padding around spectrum widget in colorpicker tooltip;r=pbro
https://hg.mozilla.org/mozilla-central/rev/e5ebff5eb655
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.