1288367 - dom/system/gonk/mozstumbler/UploadStumbleRunnable.cpp

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=abe3f0322e63&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=24296608

/home/worker/workspace/gecko/dom/system/gonk/mozstumbler/UploadStumbleRunnable.cpp:53:69: error: no matching function for call to 'nsIXMLHttpRequest::Init(nsCOMPtr<nsIPrincipal>&, std::nullptr_t, std::nullptr_t, std::nullptr_t, std::nullptr_t)'
make[6]: *** [Unified_cpp_dom_system_gonk1.o] Error 1
make[5]: *** [dom/system/gonk/target] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [realbuild] Error 2
make[1]: *** [build] Error 2
make: *** [out/target/product/aries/obj/DATA/gecko_intermediates/gecko] Error 2

Comment 1

[:gerard-majax]

09:43:09     INFO -  /home/worker/workspace/gecko/dom/system/gonk/mozstumbler/UploadStumbleRunnable.cpp: In member function 'nsresult UploadStumbleRunnable::Upload()':
09:43:09    ERROR -  /home/worker/workspace/gecko/dom/system/gonk/mozstumbler/UploadStumbleRunnable.cpp:53:69: error: no matching function for call to 'nsIXMLHttpRequest::Init(nsCOMPtr<nsIPrincipal>&, std::nullptr_t, std::nullptr_t, std::nullptr_t, std::nullptr_t)'
09:43:09     INFO -     rv = xhr->Init(systemPrincipal, nullptr, nullptr, nullptr, nullptr);
09:43:09     INFO -                                                                       ^
09:43:09     INFO -  /home/worker/workspace/gecko/dom/system/gonk/mozstumbler/UploadStumbleRunnable.cpp:53:69: note: candidate is:
09:43:09     INFO -  In file included from /home/worker/workspace/gecko/dom/system/gonk/mozstumbler/UploadStumbleRunnable.cpp:13:0,
09:43:09     INFO -                   from Unified_cpp_dom_system_gonk1.cpp:65:
09:43:09     INFO -  ../../../dist/include/nsIXMLHttpRequest.h:265:20: note: virtual nsresult nsIXMLHttpRequest::Init(nsIPrincipal*, nsIGlobalObject*, nsIURI*, nsILoadGroup*)
09:43:09     INFO -     NS_IMETHOD Init(nsIPrincipal *principal, nsIGlobalObject *globalObject, nsIURI *baseURI, nsILoadGroup *loadGroup) = 0;
09:43:09     INFO -                      ^
09:43:09     INFO -  ../../../dist/include/nsIXMLHttpRequest.h:265:20: note:   candidate expects 4 arguments, 5 provided

Comment 2

[:gerard-majax]

Attachment: Bug 1288367 - Fix XHR Init call in mozstumbler gonk

Review commit: https://reviewboard.mozilla.org/r/66012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66012/

Comment 3

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c55cb74dec4e

Comment 4

[:gerard-majax]

Comment on attachment 8773235 [details]
Bug 1288367 - Fix XHR Init call in mozstumbler gonk

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66012/diff/1-2/

Comment 5

[:gerard-majax]

Comment on attachment 8773235 [details]
Bug 1288367 - Fix XHR Init call in mozstumbler gonk

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66012/diff/2-3/

Comment 6

[:gerard-majax]

Comment on attachment 8773235 [details]
Bug 1288367 - Fix XHR Init call in mozstumbler gonk

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66012/diff/3-4/

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8773235 [details]
Bug 1288367 - Fix XHR Init call in mozstumbler gonk

https://reviewboard.mozilla.org/r/66012/#review62874

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ff8b2aeedf8
Fix XHR Init call in mozstumbler gonk r=tzimmermann

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4ff8b2aeedf8