Get rid of nsIWebBrowserChrome::CHROME_PRIVATE_WINDOW

NEW
Unassigned

Status

()

Core
Document Navigation
P3
normal
a year ago
a year ago

People

(Reporter: baku, Unassigned)

Tracking

50 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 affected)

Details

(Reporter)

Description

a year ago
nsIWebBrowserChrome::CHROME_PRIVATE_WINDOW should be replaced with OriginAttributes.mPrivateBrowsing flag.
All of CHROME_PRIVATE_WINDOW handling in child process is broken, and we just happen to propagate private browsing flag properly since we end up calling ApplyShowInfo.
Took quite some time for baku and me to debug the setup for Bug 1280105 to ensure e10s-FF48 doesn't have totally broken pb in window.open case.

Luckily Bug 1280105 removes the flag handling in child process, but I think there is still more very error prone cases in parent.
Priority: -- → P3
Depends on: 1294237
You need to log in before you can comment on or make changes to this bug.