1288423 - Remove the last references to Actor/FrontClass.

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Eddy Bruel [:ejpbruel]]

There are a few places left where we still use the old Actor/FrontClass constructors, which have been superseded by the new Actor/FrontClassWithSpec constructors.

We should remove the last references to the old constructors, and then rename the new constructors to Actor/FrontClass.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Decouple TestActor from TestFront.

Comment 2

[Eddy Bruel [:ejpbruel]]

Attachment: Decouple EventsFormActor from EventsFormFront.

Comment 3

[Eddy Bruel [:ejpbruel]]

Attachment: Decouple PerformancEntriesActor from PerformanceEntriesFront.

Comment 4

[Eddy Bruel [:ejpbruel]]

Attachment: Remove the old Actor/FrontClass constructors.

Comment 5

[Eddy Bruel [:ejpbruel]]

Attachment: Rename Actor/FrontClassWithSpec to Actor/FrontClass.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8773336 [details] [diff] [review]
Remove the old Actor/FrontClass constructors.

Review of attachment 8773336 [details] [diff] [review]:
-----------------------------------------------------------------

So satisfying!

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8773337 [details] [diff] [review]
Rename Actor/FrontClassWithSpec to Actor/FrontClass.

Review of attachment 8773337 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the assumption that this is purely mechanical -- if it isn't and there's something I should look closer at, then reflag me, please.

Fin!

Comment 8

[Eddy Bruel [:ejpbruel]]

Try push for these patches:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=29ba137a343e

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/9110bc88a18e
Decouple EventsFormActor from EventsFormFront. r=fitzgen

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/530a881ab15d
Decouple EventsFormActor from EventsFormFront. r=fitzgen

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/51c1584181ed
Decouple PerformanceEntriesActor from PerformanceEntriesFront. r=fitzgen

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/fe8feacf14f8
Remove the old Actor/FrontClass constructors. r=fitzgen

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/91a40af7390d
Rename Actor/FrontClassWithSpec to Actor/FrontClass. r=fitzgen

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9110bc88a18e
https://hg.mozilla.org/mozilla-central/rev/530a881ab15d
https://hg.mozilla.org/mozilla-central/rev/51c1584181ed
https://hg.mozilla.org/mozilla-central/rev/fe8feacf14f8
https://hg.mozilla.org/mozilla-central/rev/91a40af7390d

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I didn't notice this bug until just now...  ActorClass / FrontClass are exposed to add-ons, so I am not sure we want to remove them?  Add-ons use them to construct custom add-on specific actors.

See the usages here: (use LDAP to login)

https://dxr.mozilla.org/addons/search?q=ActorClass

Or, we could also choose to force add-ons to convert as well.  I just want to make sure we're considering the issue.  I'll mark this bug as addon-compat so it's listed in the next compatibility post.

Comment 16

[Eddy Bruel [:ejpbruel]]

I've opened bug 1295171 for this.

Comment 17

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

With bug 1295171, there is much less impact on add-ons.  Existing add-ons should continue to functions as before, and they have a choice to convert to the new path we're using in-tree if they wish to.  I'll leave the addon-compat keyword, just so add-on authors can be aware of what's changing.