Closed Bug 1288423 Opened 3 years ago Closed 3 years ago

Remove the last references to Actor/FrontClass.

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Iteration:
50.4 - Aug 1
Tracking Status
firefox51 --- fixed

People

(Reporter: ejpbruel, Assigned: ejpbruel)

References

Details

(Keywords: addon-compat)

Attachments

(5 files)

There are a few places left where we still use the old Actor/FrontClass constructors, which have been superseded by the new Actor/FrontClassWithSpec constructors.

We should remove the last references to the old constructors, and then rename the new constructors to Actor/FrontClass.
Whiteboard: [devtools-html] [triage]
Blocks: 1263289
Attachment #8773333 - Flags: review?(nfitzgerald)
Attachment #8773334 - Flags: review?(nfitzgerald)
Attachment #8773336 - Flags: review?(nfitzgerald)
Attachment #8773333 - Flags: review?(nfitzgerald) → review+
Status: NEW → ASSIGNED
Iteration: --- → 50.4 - Aug 1
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
Attachment #8773334 - Flags: review?(nfitzgerald) → review+
Attachment #8773335 - Flags: review?(nfitzgerald) → review+
Comment on attachment 8773336 [details] [diff] [review]
Remove the old Actor/FrontClass constructors.

Review of attachment 8773336 [details] [diff] [review]:
-----------------------------------------------------------------

So satisfying!
Attachment #8773336 - Flags: review?(nfitzgerald) → review+
Comment on attachment 8773337 [details] [diff] [review]
Rename Actor/FrontClassWithSpec to Actor/FrontClass.

Review of attachment 8773337 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the assumption that this is purely mechanical -- if it isn't and there's something I should look closer at, then reflag me, please.

Fin!
Attachment #8773337 - Flags: review?(nfitzgerald) → review+
Pushed by ejpbruel@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/9110bc88a18e
Decouple EventsFormActor from EventsFormFront. r=fitzgen
Pushed by ejpbruel@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/530a881ab15d
Decouple EventsFormActor from EventsFormFront. r=fitzgen
Pushed by ejpbruel@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/51c1584181ed
Decouple PerformanceEntriesActor from PerformanceEntriesFront. r=fitzgen
Pushed by ejpbruel@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/fe8feacf14f8
Remove the old Actor/FrontClass constructors. r=fitzgen
Pushed by ejpbruel@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/91a40af7390d
Rename Actor/FrontClassWithSpec to Actor/FrontClass. r=fitzgen
I didn't notice this bug until just now...  ActorClass / FrontClass are exposed to add-ons, so I am not sure we want to remove them?  Add-ons use them to construct custom add-on specific actors.

See the usages here: (use LDAP to login)

https://dxr.mozilla.org/addons/search?q=ActorClass

Or, we could also choose to force add-ons to convert as well.  I just want to make sure we're considering the issue.  I'll mark this bug as addon-compat so it's listed in the next compatibility post.
Flags: needinfo?(ejpbruel)
Keywords: addon-compat
I've opened bug 1295171 for this.
Flags: needinfo?(ejpbruel)
With bug 1295171, there is much less impact on add-ons.  Existing add-ons should continue to functions as before, and they have a choice to convert to the new path we're using in-tree if they wish to.  I'll leave the addon-compat keyword, just so add-on authors can be aware of what's changing.
Blocks: 1295171
Whiteboard: [devtools-html]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.