1288475 - Split webconsole utils file into client and server parts

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

The webconsole utils file is in shared/ but mostly it's used by the server.  Let's split it into two files and put it in their respective places.

Here's the stuff being used by client:

https://dxr.mozilla.org/mozilla-central/search?q=path:devtools/client+%22WebConsoleUtils.%22

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1288475 - Split webconsole utils.js into separate client and server parts

Review commit: https://reviewboard.mozilla.org/r/69326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69326/

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1288475 - Remove code unused in client and server versions of webconsole utils;

Review commit: https://reviewboard.mozilla.org/r/69328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69328/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8777966 [details]
Bug 1288475 - Split webconsole utils.js into separate client and server parts

Matt, can you have a look at the change in toolkit/components/passwordmgr/InsecurePasswordUtils.jsm? I got rid of a dependency on a small wrapper for Services.strings from the webconsole: https://dxr.mozilla.org/mozilla-central/source/devtools/shared/webconsole/utils.js#542.

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8777966 [details]
Bug 1288475 - Split webconsole utils.js into separate client and server parts

https://reviewboard.mozilla.org/r/69326/#review66542

r=me on InsecurePasswordUtils.jsm

Comment 5

[Tom Tromey :tromey]

Comment on attachment 8777966 [details]
Bug 1288475 - Split webconsole utils.js into separate client and server parts

https://reviewboard.mozilla.org/r/69326/#review66708

Thank you.  This looks good.

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8777967 [details]
Bug 1288475 - Remove code unused in client and server versions of webconsole utils;

https://reviewboard.mozilla.org/r/69328/#review66710

Thank you.  This looks great, I love deletions.

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8777966 [details]
Bug 1288475 - Split webconsole utils.js into separate client and server parts

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69326/diff/1-2/

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8777967 [details]
Bug 1288475 - Remove code unused in client and server versions of webconsole utils;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69328/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8795e6dad405
Split webconsole utils.js into separate client and server parts;r=MattN,tromey
https://hg.mozilla.org/integration/autoland/rev/4da5f346fddf
Remove code unused in client and server versions of webconsole utils;r=tromey

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8795e6dad405
https://hg.mozilla.org/mozilla-central/rev/4da5f346fddf