Closed
Bug 1288533
Opened 8 years ago
Closed 8 years ago
Port Bug 1262731 to Seamonkey: Don't use a separate ICU data file on Windows.
Categories
(SeaMonkey :: Installer, defect)
Tracking
(seamonkey2.44 unaffected, seamonkey2.45 affected, seamonkey2.46 affected, seamonkey2.47 fixed)
RESOLVED
FIXED
seamonkey2.47
| Tracking | Status | |
|---|---|---|
| seamonkey2.44 | --- | unaffected |
| seamonkey2.45 | --- | affected |
| seamonkey2.46 | --- | affected |
| seamonkey2.47 | --- | fixed |
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(1 file)
|
1.32 KB,
patch
|
ewong
:
review+
iannbugzilla
:
approval-comm-aurora+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Bug 1262731 needs to be ported otherwise make installer will not work because of a missing icu data file.
|
Assignee | |
Updated•8 years ago
|
Assignee: installer → frgrahl
status-seamonkey2.44:
--- → unaffected
status-seamonkey2.45:
--- → affected
status-seamonkey2.46:
--- → affected
status-seamonkey2.47:
--- → affected
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8773477 [details] [diff] [review] 1288533-icudata.patch Review of attachment 8773477 [details] [diff] [review]: ----------------------------------------------------------------- Lgtm
Attachment #8773477 -
Flags: review?(ewong) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/201d96fc8820
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8773477 [details] [diff] [review] 1288533-icudata.patch [Approval Request Comment] Regression caused by (bug #): 1262731 User impact if declined: build break. Testing completed (on m-c, etc.): c-b and c-a Risk to taking this patch (and alternatives if risky): no risk. It fixes build bustage. String changes made by this patch: none
Attachment #8773477 -
Flags: approval-comm-beta?
Attachment #8773477 -
Flags: approval-comm-aurora?
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
QA Contact: frgrahl
|
|
Assignee | |
Updated•8 years ago
|
QA Contact: frgrahl
Comment on attachment 8773477 [details] [diff] [review] 1288533-icudata.patch a=me
Attachment #8773477 -
Flags: approval-comm-beta?
Attachment #8773477 -
Flags: approval-comm-beta+
Attachment #8773477 -
Flags: approval-comm-aurora?
Attachment #8773477 -
Flags: approval-comm-aurora+
|
|
||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/22a1466a02a37edb284ef8b4f18c1daa445a221d Bug 1288533 - Don't use separate ICU data file on Windows. r=ewong a=IanN
|
|
||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/releases/comm-beta/rev/0e8f0295298db6bc6ca5ee126459a30b19245950 Bug 1288533 - Don't use separate ICU data file on Windows. r=ewong a=IanN
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8773477 [details] [diff] [review] 1288533-icudata.patch Pushed to comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/22a1466a02a3 Pushed to comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/0e8f0295298d
|
|
||
Comment 9•8 years ago
|
||
Oh. sorry for the repeated entry. Didn't realize they actually have this pushlog post.
|
|
||
Comment 10•8 years ago
|
||
Thanks Frank-Rainer!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•