Closed Bug 1288582 Opened 3 years ago Closed 3 years ago

Hide Adobe Primetime plugin on Windows < Vista

Categories

(Toolkit :: General, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox47 --- wontfix
firefox48 - wontfix
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file)

We're not going to get support for Adobe Primetime on WinXP, so we should hide the plugin from our add-ons manager.
We're not going to get a supported Adobe GMP on WinXP, so we shouldn't download
it or show it in our add-on manager.

Review commit: https://reviewboard.mozilla.org/r/66278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66278/
Attachment #8773578 - Flags: review?(spohl.mozilla.bugs)
Attachment #8773578 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8773578 [details]
Bug 1288582 - Hide Adobe Primetime plugin on Windows < Vista.

https://reviewboard.mozilla.org/r/66278/#review63086

::: toolkit/modules/GMPUtils.jsm:87
(Diff revision 1)
>        return AppConstants.isPlatformAndVersionAtLeast("win", "6") ||
>               AppConstants.platform == "macosx" ||
>               AppConstants.platform == "linux";
>      }
>  
>      return true;

I'm wondering if the default return value here should actually be false. But this doesn't need to happen in this bug.
All pre-release branches are affected, but 47 is not.

[Tracking Requested - why for this release]:

This causes the Adobe Primetime CDM to appear in the plugins list in about:addons on Windows XP, even though the Adobe CDM can't be used for anything on WinXP. This will cause our WinXP users to download it, even though it won't do anything for them.

The Adobe CDM doesn't work for EME on WinXP, and we were trying to get it working for unencrypted decoding of MP4/H.264/AAC files on WinXP, but it has a bug that causes it to crash on some systems. So we turned unencrypted decoding via the Adobe GMP off. Adobe have decided that they aren't going to support WinXP furthermore, so they're not going to be fixing that bug. We don't want to use unsupported decoder for unencrypted decoding. So there's no point showing the Adobe CDM in the addons/plugins list and downloading it on WinXP, as it'll never be used for anything.

I think we should remove this the Adobe CDM from the plugins list in 48, since it doesn't do anything, and will waste our users' bandwidth if we leave it there.
Comment on attachment 8773578 [details]
Bug 1288582 - Hide Adobe Primetime plugin on Windows < Vista.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66278/diff/1-2/
(In reply to Chris Pearce (:cpearce) from comment #4)
> Comment on attachment 8773578 [details]
> Bug 1288582 - Hide Adobe Primetime plugin on Windows < Vista.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/66278/diff/1-2/

(Reordered patch slightly to make the patch easier to uplift).
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d78a8f4bd9cc
Hide Adobe Primetime plugin on Windows < Vista. r=spohl
(In reply to Stephen A Pohl [:spohl] from comment #2)
> I'm wondering if the default return value here should actually be false. But
> this doesn't need to happen in this bug.

I expect that would break OpenH264, which is available on all tier-1 platforms.
backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=881914&repo=autoland
Flags: needinfo?(cpearce)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2868c140a299
Backed out changeset d78a8f4bd9cc for windows failures in browser_gmpProvider.js
Component: General → Audio/Video: GMP
Product: Firefox → Core
Rank: 15
Priority: -- → P1
This is an issue in the Firefox GMP downloader code, not GMP harness. So moving back to Firefox.
Component: Audio/Video: GMP → General
Product: Core → Firefox
After discussion with Gijs, we agreed to move this out of Firefox::General to Toolkit::General, since all this code lives in /toolkit/...
Product: Firefox → Toolkit
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6621ce9a618b
Hide Adobe Primetime plugin on Windows < Vista. r=spohl
(In reply to Carsten Book [:Tomcat] from comment #8)
> backed out for test failures like
> https://treeherder.mozilla.org/logviewer.html#?job_id=881914&repo=autoland

Relanded.
Flags: needinfo?(cpearce)
https://hg.mozilla.org/mozilla-central/rev/6621ce9a618b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8773578 [details]
Bug 1288582 - Hide Adobe Primetime plugin on Windows < Vista.

Requesting uplift for Firefox 48 and 49.

Approval Request Comment
[Feature/regressing bug #]: Unencrypted MP4 decoding (which is now disabled)
[User impact if declined]: Users on Windows XP will have the "Primetime Content Decryption Module provided by Adobe Systems, Incorporated" appear in the Add-ons Manager > Plugins list. Firefox will download this plugin, but it won't be used for anything. Adobe EME doesn't work on WinXP, and we disabled using the Adobe GMP for unencrypted decoding. This may confuse users, and waste their bandwidth. There will not be any other consequences, i.e. this is not a crash/security fix.
[Describe test coverage new/current, TreeHerder]: We have test coverage for the feature being patched, and the patch updates the test.
[Risks and why]: Low, we have test coverage asserting that we get the behaviour we expect.
[String/UUID change made/needed]: None.
Attachment #8773578 - Flags: approval-mozilla-release?
Attachment #8773578 - Flags: approval-mozilla-beta?
Attachment #8773578 - Flags: approval-mozilla-aurora?
Comment on attachment 8773578 [details]
Bug 1288582 - Hide Adobe Primetime plugin on Windows < Vista.

Because it's late beta, it only impacts a few users in windows XP, and it won't cause firefox crash and we've already kick off the 48 RC2 and it will go live today, let's won't fix this in 48 and release, and let it ride the train on 49.
Attachment #8773578 - Flags: approval-mozilla-release?
Attachment #8773578 - Flags: approval-mozilla-release-
Attachment #8773578 - Flags: approval-mozilla-beta?
Attachment #8773578 - Flags: approval-mozilla-beta-
Attachment #8773578 - Flags: approval-mozilla-aurora?
Attachment #8773578 - Flags: approval-mozilla-aurora+
This will cause *all* our users on Windows XP to download the Adobe GMP. That's 15% of our several hundred million users, right?
Why did you do it? This plugin is well helped me play h264 video on my Windows XP, no errors were not.
Add the ability to include this plug-in for those who have everything working perfectly.
(In reply to sumanai from comment #20)
> Why did you do it?

answer is here
(In reply to Chris Pearce (:cpearce) from comment #3)
> Adobe have decided that they aren't going to
> support WinXP furthermore, so they're not going to be fixing that bug. We
> don't want to use unsupported decoder for unencrypted decoding.
(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #21)
> (In reply to sumanai from comment #20)
> > Why did you do it?
> 
> answer is here
But specifically I have not observed any crash!
It may give the option to activate this plugin manually for advanced users who still work?
It's actually possible to enable it back in versions 49 and later, including 52 ESR.

I've found the instructions here: http://www.msfn.org/board/topic/175591-enable-mp4-h264-aac-html5-video-in-firefox-on-windows-xp-without-flash/

You have to set or create these variables in about:config:
media.gmp-eme-adobe.enabled (boolean, true)
media.gmp-eme-adobe.forceSupported (boolean, true)
media.gmp-eme-adobe.visible (boolean, true)
media.gmp.decoder.enabled (boolean, true)
media.eme.enabled (boolean, true)

If you have 52 ESR and haven't migrated your profile from a previous version with the plugin already downloaded, edit media.gmp-manager.url and replace %VERSION% with 51.0, then it'll be able to download it. Go to Add-ons, Plugins, the Primetime plugin should be there, saying that it'll be installed shortly, click Check for Updates in the gear menu, it'll be downloaded right away.
You need to log in before you can comment on or make changes to this bug.