Rename HTMLInputElement::directory to HTMLInputElement::allowdirs

RESOLVED FIXED in Firefox 50

Status

()

defect
RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

({dev-doc-complete})

50 Branch
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

3 years ago
Posted patch allow.patch (obsolete) — Splinter Review
No description provided.
Attachment #8773703 - Flags: review?(bugs)
Assignee

Comment 1

3 years ago
Posted patch allow.patch (obsolete) — Splinter Review
Attachment #8773703 - Attachment is obsolete: true
Attachment #8773703 - Flags: review?(bugs)
Attachment #8773709 - Flags: review?(bugs)
Assignee

Updated

3 years ago
Blocks: 1188880
Comment on attachment 8773709 [details] [diff] [review]
allow.patch

>+  bool Allowdirs() const
>   {
>     return HasAttr(kNameSpaceID_None, nsGkAtoms::directory);
nsGkAtoms::directory?

>   }
> 
>-  void SetDirectoryAttr(bool aValue, ErrorResult& aRv)
>+  void SetAllowdirs(bool aValue, ErrorResult& aRv)
>   {
>     SetHTMLBoolAttr(nsGkAtoms::directory, aValue, aRv);
ditto

And don't you need to fix the tests too.
Attachment #8773709 - Flags: review?(bugs) → review-
Assignee

Comment 3

3 years ago
Posted patch allow.patchSplinter Review
Attachment #8773709 - Attachment is obsolete: true
Attachment #8773756 - Flags: review?(bugs)
Comment on attachment 8773756 [details] [diff] [review]
allow.patch

make sure to push this to try, since perhaps some cases were missed here.
Attachment #8773756 - Flags: review?(bugs) → review+

Comment 5

3 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad0b8a6f047d
Rename HTMLInputElement::directory to HTMLInputElement::allowdirs, r=smaug

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ad0b8a6f047d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Documentation updated:

https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement

I’ve just added allowdirs to this page, noting it’s nonstandard and preffed off, and added a note to Firefox 50 for devs that this name changed.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.