1288681 - Rename HTMLInputElement::directory to HTMLInputElement::allowdirs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: allow.patch

Comment 1

[Andrea Marchesini [:baku]]

Attachment: allow.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8773709 [details] [diff] [review]
allow.patch

>+  bool Allowdirs() const
>   {
>     return HasAttr(kNameSpaceID_None, nsGkAtoms::directory);
nsGkAtoms::directory?

>   }
> 
>-  void SetDirectoryAttr(bool aValue, ErrorResult& aRv)
>+  void SetAllowdirs(bool aValue, ErrorResult& aRv)
>   {
>     SetHTMLBoolAttr(nsGkAtoms::directory, aValue, aRv);
ditto

And don't you need to fix the tests too.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: allow.patch

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8773756 [details] [diff] [review]
allow.patch

make sure to push this to try, since perhaps some cases were missed here.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad0b8a6f047d
Rename HTMLInputElement::directory to HTMLInputElement::allowdirs, r=smaug

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ad0b8a6f047d

Comment 7

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement

I’ve just added allowdirs to this page, noting it’s nonstandard and preffed off, and added a note to Firefox 50 for devs that this name changed.