Closed Bug 1288681 Opened 4 years ago Closed 4 years ago

Rename HTMLInputElement::directory to HTMLInputElement::allowdirs

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 2 obsolete files)

Attached patch allow.patch (obsolete) — Splinter Review
No description provided.
Attachment #8773703 - Flags: review?(bugs)
Attached patch allow.patch (obsolete) — Splinter Review
Attachment #8773703 - Attachment is obsolete: true
Attachment #8773703 - Flags: review?(bugs)
Attachment #8773709 - Flags: review?(bugs)
Blocks: 1188880
Comment on attachment 8773709 [details] [diff] [review]
allow.patch

>+  bool Allowdirs() const
>   {
>     return HasAttr(kNameSpaceID_None, nsGkAtoms::directory);
nsGkAtoms::directory?

>   }
> 
>-  void SetDirectoryAttr(bool aValue, ErrorResult& aRv)
>+  void SetAllowdirs(bool aValue, ErrorResult& aRv)
>   {
>     SetHTMLBoolAttr(nsGkAtoms::directory, aValue, aRv);
ditto

And don't you need to fix the tests too.
Attachment #8773709 - Flags: review?(bugs) → review-
Attached patch allow.patchSplinter Review
Attachment #8773709 - Attachment is obsolete: true
Attachment #8773756 - Flags: review?(bugs)
Comment on attachment 8773756 [details] [diff] [review]
allow.patch

make sure to push this to try, since perhaps some cases were missed here.
Attachment #8773756 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad0b8a6f047d
Rename HTMLInputElement::directory to HTMLInputElement::allowdirs, r=smaug
https://hg.mozilla.org/mozilla-central/rev/ad0b8a6f047d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Keywords: dev-doc-needed
Documentation updated:

https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement

I’ve just added allowdirs to this page, noting it’s nonstandard and preffed off, and added a note to Firefox 50 for devs that this name changed.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.