1288715 - Refactor SharedScriptData

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: refactor-shared-script-data

In preparation for possibly changing the way we sweep shared script data, I did some refactoring.

The patch makes it so there is a single pointer from a JSScript to a SharedScriptData and removes some duplicated state between the two.

It changes the data layout so that atoms are stored first in the SharedScriptData.  This means that we don't need padding which makes the allocation simpler.

And also a bunch of other tidy-up.

Comment 1

[Till Schneidereit [:till]]

Comment on attachment 8773722 [details] [diff] [review]
refactor-shared-script-data

Review of attachment 8773722 [details] [diff] [review]:
-----------------------------------------------------------------

This looks so much nicer and cleaner.

::: js/src/jsscript.cpp
@@ +2410,5 @@
>                             uint32_t srcnotesLength, uint32_t natoms)
>  {
>      /*
>       * Ensure the atoms are aligned, as some architectures don't allow unaligned
>       * access.

Do we still need this comment? With atoms coming first, it seems self-evident that this holds.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a68a478c299d
Refactor SharedScriptData to prepare for making it refcounted r=till

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a68a478c299d