Improve mach command for running mochitest from a tests.zip

RESOLVED FIXED in Firefox 50

Status

Testing
Mochitest
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

(Blocks: 1 bug)

unspecified
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
Currently mochitest requires --appname to be passed in, though recently some code landed to find appname automagically. It also doesn't properly normalize test paths if developers use an unexpected relative url.
(Assignee)

Comment 1

11 months ago
Created attachment 8774825 [details]
Bug 1288827 - Allow running mochitest from test-package without specifying --appname,

Because it is now possible for options.app to get set after 'parse_args' time, we need to make sure
the argument validation happens later. To accomplish this we pass in the parser instance to
'run_test_harness' and do parser.validate there. This unfortunately requires some minor uses of
global to accomplish easily due to how mach handles parsers.

Review commit: https://reviewboard.mozilla.org/r/67226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67226/
Attachment #8774825 - Flags: review?(armenzg)

Updated

11 months ago
Attachment #8774825 - Flags: review?(armenzg) → review+

Comment 2

11 months ago
Comment on attachment 8774825 [details]
Bug 1288827 - Allow running mochitest from test-package without specifying --appname,

https://reviewboard.mozilla.org/r/67226/#review64450

You have to what you have to do!
It's fine to use a global.

Comment 3

11 months ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6dcb52d270c7
Allow running mochitest from test-package without specifying --appname, r=armenzg

Comment 4

11 months ago
sorry had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=1095224&repo=autoland
Flags: needinfo?(ahalberstadt)

Comment 5

11 months ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6a7c3753a06
Backed out changeset 6dcb52d270c7 for breaking mochitests
(Assignee)

Comment 6

11 months ago
Comment on attachment 8774825 [details]
Bug 1288827 - Allow running mochitest from test-package without specifying --appname,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67226/diff/1-2/
(Assignee)

Comment 7

11 months ago
Sorry about that, the above patch should fix it. I could have sworn I had those changes already but must have messed up a split or forgot to amend or something.

I'll wait for the try run there to complete before landing again.
Flags: needinfo?(ahalberstadt)
(Assignee)

Comment 8

11 months ago
Here's the try run from mozreview:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba58516f6cc0e7c3eca952bb0e2603e53f51162d

Comment 9

11 months ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52f229a7749e
Allow running mochitest from test-package without specifying --appname, r=armenzg

Comment 10

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/52f229a7749e
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
(Assignee)

Updated

11 months ago
Depends on: 1292660
You need to log in before you can comment on or make changes to this bug.