1288827 - Improve mach command for running mochitest from a tests.zip

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Andrew Halberstadt [:ahal]]

Currently mochitest requires --appname to be passed in, though recently some code landed to find appname automagically. It also doesn't properly normalize test paths if developers use an unexpected relative url.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1288827 - Allow running mochitest from test-package without specifying --appname,

Because it is now possible for options.app to get set after 'parse_args' time, we need to make sure
the argument validation happens later. To accomplish this we pass in the parser instance to
'run_test_harness' and do parser.validate there. This unfortunately requires some minor uses of
global to accomplish easily due to how mach handles parsers.

Review commit: https://reviewboard.mozilla.org/r/67226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67226/

Comment 2

[Armen [:armenzg]]

Comment on attachment 8774825 [details]
Bug 1288827 - Allow running mochitest from test-package without specifying --appname,

https://reviewboard.mozilla.org/r/67226/#review64450

You have to what you have to do!
It's fine to use a global.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dcb52d270c7
Allow running mochitest from test-package without specifying --appname, r=armenzg

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=1095224&repo=autoland

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6a7c3753a06
Backed out changeset 6dcb52d270c7 for breaking mochitests

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8774825 [details]
Bug 1288827 - Allow running mochitest from test-package without specifying --appname,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67226/diff/1-2/

Comment 7

[Andrew Halberstadt [:ahal]]

Sorry about that, the above patch should fix it. I could have sworn I had those changes already but must have messed up a split or forgot to amend or something.

I'll wait for the try run there to complete before landing again.

Comment 8

[Andrew Halberstadt [:ahal]]

Here's the try run from mozreview:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba58516f6cc0e7c3eca952bb0e2603e53f51162d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52f229a7749e
Allow running mochitest from test-package without specifying --appname, r=armenzg

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/52f229a7749e