Closed Bug 1288841 Opened 3 years ago Closed 3 years ago

Add typelib information for IServiceProvider and IEnumVARIANT

Categories

(Core :: Disability Access APIs, defect)

Unspecified
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- affected
firefox51 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We need to build a typelib for these interfaces since they aren't included with the OS. This is requires so that the COM interceptor can properly build proxies.
Comment on attachment 8773951 [details]
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT;

https://reviewboard.mozilla.org/r/66584/#review63602

::: accessible/ipc/win/typelib/Makefile.in:8
(Diff revision 1)
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +GARBAGE += $(MIDL_GENERATED_FILES) done_gen dlldata.c
> +
> +MIDL_GENERATED_FILES = \
> +	Accessible.h \

Similar to the other bug, you should use spaces instead of tabs here. Tabs have a special meaning in Makefiles, and should only be used in recipes (such as the $(MIDL) $(MIDL_FLAGS)... line below)

::: accessible/ipc/win/typelib/Makefile.in:23
(Diff revision 1)
> +	touch $@
> +
> +export:: done_gen
> +
> +midl_exports := \
> +		Accessible.tlb \

tabs -> spaces
Attachment #8773951 - Flags: review?(mshal) → review+
Attachment #8773951 - Flags: review?(tbsaunde+mozbugs) → review+
Comment on attachment 8773951 [details]
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66584/diff/1-2/
Attachment #8773951 - Flags: review+ → review?(tbsaunde+mozbugs)
Attachment #8773951 - Flags: review?(tbsaunde+mozbugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/17dc46beb1a559af1df3ea63d621e7d79f4027cc
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal
https://hg.mozilla.org/mozilla-central/rev/17dc46beb1a5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9f49a1192559dd939a0b10fa8c2335bda40afff
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal
Flags: needinfo?(aklotz)
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce6e2c41d939f533272a6356efc6c64b69c8f3a4
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal
Had to back this out to successfully back bug 1268544 out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac95bd5946812806300a6c9a4beed824e46f2c81
Status: RESOLVED → REOPENED
Flags: needinfo?(aklotz)
Resolution: FIXED → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf20e2879a4e8e52e8af7641cf913f3f20859b10
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal
https://hg.mozilla.org/mozilla-central/rev/bf20e2879a4e
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Flags: needinfo?(aklotz)
Depends on: 1319640
You need to log in before you can comment on or make changes to this bug.