1288841 - Add typelib information for IServiceProvider and IEnumVARIANT

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

We need to build a typelib for these interfaces since they aren't included with the OS. This is requires so that the COM interceptor can properly build proxies.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT;

Review commit: https://reviewboard.mozilla.org/r/66584/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66584/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8773951 [details]
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT;

https://reviewboard.mozilla.org/r/66584/#review63602

::: accessible/ipc/win/typelib/Makefile.in:8
(Diff revision 1)
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +GARBAGE += $(MIDL_GENERATED_FILES) done_gen dlldata.c
> +
> +MIDL_GENERATED_FILES = \
> +	Accessible.h \

Similar to the other bug, you should use spaces instead of tabs here. Tabs have a special meaning in Makefiles, and should only be used in recipes (such as the $(MIDL) $(MIDL_FLAGS)... line below)

::: accessible/ipc/win/typelib/Makefile.in:23
(Diff revision 1)
> +	touch $@
> +
> +export:: done_gen
> +
> +midl_exports := \
> +		Accessible.tlb \

tabs -> spaces

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8773951 [details]
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66584/diff/1-2/

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/17dc46beb1a559af1df3ea63d621e7d79f4027cc
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out with also bug 1268544 and bug 1288843: https://hg.mozilla.org/integration/mozilla-inbound/rev/3ec53f8c2d48

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=49c695f2102f

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/17dc46beb1a5

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9f49a1192559dd939a0b10fa8c2335bda40afff
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal

Comment 9

[Phil Ringnalda (:philor)]

Backed that out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1ea96bf70664 for incomprehensibly causing Win7 debug Marionette e10s to fail, https://treeherder.mozilla.org/logviewer.html#?job_id=34078720&repo=mozilla-inbound

Comment 10

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce6e2c41d939f533272a6356efc6c64b69c8f3a4
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Had to back this out to successfully back bug 1268544 out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac95bd5946812806300a6c9a4beed824e46f2c81

Comment 12

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf20e2879a4e8e52e8af7641cf913f3f20859b10
Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bf20e2879a4e