1288927 - Focus ring is shown by default when clicking a link on linux build

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[teo8976]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36

Steps to reproduce:

Visit http://jsbin.com/nafoyo
Click on the text link or on the image link


Actual results:

The focused link has a horrible, dashed outline. In the case of multiline text links, every line has its own rectangle outline.


Expected results:

The link shouldn't have a horrible outline by default. I know it can be changed with CSS, but the default shuld be reasonable, and it is not. It's plain awful, and unlike any other browser

Comment 1

[Tooru Fujisawa [:arai]]

Can you clarify the "horrible" and "reasonable" ?

Also, can you post the screenshot?

Comment 2

[julesmyers2011]

When you say "focused link" do you mean when you press down the left mouse button onto the link? Is that when the dotted box shows up? 

I went to the webpage you have linked. I was unable to reproduce what I think is the issue of a dotted box showing up when hovering or clicking on link or image. I tried in both the FF Nightly 50.0a1 (2016-7-25) and the latest version of Chrome(51). The only thing I see is an underline for the text link.

Comment 3

[teo8976]

> When you say "focused link" do you mean when you press down the left mouse button onto the link?
> Is that when the dotted box shows up? 

Yes, and then it remains until I click somewhere else (or give focus to another application)

I'll attach two screenshots

Comment 4

[teo8976]

Attachment: Screenshot: text link clicked

Comment 5

[teo8976]

Attachment: Screenshot: image link clicked

Comment 6

[julesmyers2011]

teo8976: Is your operating system Linux? If so, do you have another operating system you can try?

Your coding in JS Bin is really simple, so I can see why you think it is the default CSS style sheet that comes with the browser. 

I am unable to reproduce the issue and I have OSX Yosemite 10.10.2.

Comment 7

[Tooru Fujisawa [:arai]]

(In reply to julesmyers2011 from comment #6)
> I am unable to reproduce the issue and I have OSX Yosemite 10.10.2.

The focus ring doesn't appear by clicking on OSX.
you need to hit "Tab" key first.

Comment 8

[julesmyers2011]

Yes, hitting tab does make a solid line around the links on OSX. It looks like default behavior programmed into the browser. I believe at this point if you want a current feature to be changed, you need to put in a request to change the feature and a solid reason as to why the feature needs to be changed.

Comment 9

[teo8976]

> teo8976: Is your operating system Linux? 

Yes, Ubuntu 15.10.

> If so, do you have another operating system you can try?

No.

> Yes, hitting tab does make a solid line around the links on OSX.

And that's the expected behavior.

However, on Linux, by just CLICKING on the link (NOT hitting tab), you get the dotted border, as in my screenshots. That's the bug. It isn't supposed to show up when clicking on a link.

Comment 10

[Tooru Fujisawa [:arai]]

So, this bug is about when to show the focus ring, and not about its style, right?

Comment 11

[teo8976]

I think so, yes. 

I hadn't realised that the border I'm seeing when clicking on the link is the one I'm supposed to see when focusing an element with tab. When using the keyboard, you do have to highlight the element in some way, because it's essential for usability; it's not so important that it looks particularly good by default, and a dashed border is a pretty common convention.
I assumed that the link was being set to a legitimate state when clicking on it, and that the default style associated to that state was the dashed border, which would be a demential default style for a clicked link (too strange a style for too common a situation to be an acceptable default).
It seems instead that when clicked it's wrongly getting in the state where it is supposed to be when focused by using the keyboard.

However you shouldn't set the needinfo status for a question like this.

Comment 12

[Tooru Fujisawa [:arai]]

Thank you for the info :)

Looks like it's related to bug 418521, there the behavior was made consistent with the OS's other browsers (at least on Windows and OS X).

And here's the current behavior for each case


           Clicking a link shows focus ring?

 OS           | Browser   | text | multi line text | image
--------------+-----------+------+-----------------+-------
 Windows xp   | Firefox   | yes  | yes             | yes
              | IE8       | yes  | yes             | yes
              | Chrome    | no   | no              | no
--------------+-----------+------+-----------------+-------
 Windows 7    | Firefox   | no   | no              | no
              | IE11      | no   | no              | no
              | Chrome    | no   | no              | no
--------------+-----------+------+-----------------+-------
 Windows 8.1  | Firefox   | no   | no              | no
              | IE11      | no   | no              | no
              | Chrome    | no   | no              | no
--------------+-----------+------+-----------------+-------
 Windows 10   | Firefox   | no   | no              | no
              | IE11      | no   | no              | no
              | Edge      | no   | no              | no
              | Chrome    | no   | no              | no
--------------+-----------+------+-----------------+-------
 OS X 10.11   | Firefox   | no   | no              | no
              | Chrome    | no   | no              | no
              | Safari    | no   | no              | no
--------------+-----------+------+-----------------+-------
 Linux        | Firefox   | yes  | yes             | yes
              | Chrome    | no   | no              | no
              | Konqueror | yes  | no              | yes
              | Midori    | yes  | yes             | yes


I'm not sure what to follow on Linux tho, currently the behavior matches to Midori.
(and maybe Konqueror too, but I'm not sure why it does differently for single line and multi line text...)

Comment 13

[Tooru Fujisawa [:arai]]

[parity-chrome] might not be appropriate yet.

Comment 14

[Neil Deakin]

The bug here is that the focus ring should not appear when clicking the mouse on a link. 

Is this a regression?

Comment 15

[Tooru Fujisawa [:arai]]

(In reply to Neil Deakin from comment #14)
> Is this a regression?

I don't see any behavior change from Firefox 4.0.
not sure about older versions (I cannot run them)