Closed Bug 1288964 Opened 7 years ago Closed 7 years ago

The reload button does not work in Canvas Debugger or Web Audio Editor

Categories

(DevTools :: General, defect, P1)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(firefox49 unaffected, firefox50 verified, firefox51 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox49 --- unaffected
firefox50 --- verified
firefox51 --- verified

People

(Reporter: magicp.jp, Assigned: jryans)

References

Details

(Keywords: regression)

Attachments

(2 files)

steps-to-reproduce.mp4
2.18 MB, video/mp4
Details
Repair reload for canvas and web audio
1.81 KB, patch
jryans
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached video steps-to-reproduce.mp4 — 
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160724030208

Steps to reproduce:

1. Start Nightly
2. Go to "http://helloracer.com/webgl/"
3. Open DevTools > Canvas
4. Click "Reload" button


Actual results:

After step 4, record-snapshot button does not displayed on snapshots-toolbar. And also reload-notice-button is not replaced to canvas-debugging-empty-notice-button.
But if clicking clear-snapshots, canvas-debugging-empty-notice-button is displayed.


Expected results:

Is this behavior intentional? If this is not, record-snapshot button and canvas-debugging-empty-notice-button are displayed after step 4.
Has STR: --- → yes
status-firefox49: --- → unaffected
status-firefox50: --- → affected
Component: Untriaged → Developer Tools: Canvas Debugger
OS: Unspecified → All
Hardware: Unspecified → All
status-firefox51: --- → affected
Thanks for noticing this regression.  I'll take a look.
Assignee: nobody → jryans
Blocks: 1240907
Status: NEW → ASSIGNED
Keywords: regression
Priority: -- → P1
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/477ce21512ea
Restore reload buttons in canvas and web audio. r=me
Web audio is also affected.
Component: Developer Tools: Canvas Debugger → Developer Tools
Summary: The reload button does not work in Canvas debugger → The reload button does not work in Canvas Debugger or Web Audio Editor
https://hg.mozilla.org/mozilla-central/rev/477ce21512ea
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment on attachment 8777603 [details] [diff] [review]
Repair reload for canvas and web audio

Approval Request Comment
[Feature/regressing bug #]: Bug 1288964
[User impact if declined]: Reload buttons that appear in the UI of the Canvas Debugger and Web Audio Editor won't work, making those tools appear broken
[Describe test coverage new/current, TreeHerder]: On m-c
[Risks and why]: Low, just checks the reload flag as needed
[String/UUID change made/needed]: None
Attachment #8777603 - Flags: approval-mozilla-aurora?
Comment on attachment 8777603 [details] [diff] [review]
Repair reload for canvas and web audio

Regression, Aurora50+
Attachment #8777603 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Hello, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(magicp.jp)
(In reply to Ritu Kothari (:ritu) from comment #12)
> Hello, could you please verify this issue is fixed as expected on a latest
> Nightly build? Thanks!

Hi Ritu, This issue was fixed in Nightly build (20160805030444). Thanks!
Flags: needinfo?(magicp.jp)
I have reproduced this bug with Nightly 50.0a1 (2016-07-24) on Ubuntu 14.04, 64 bit!
The bug's fix is now verified on latest Nightly 51.0a1 and latest Aurora 50.0a2

Nightly 51.0a1:
Build ID 	20160807030201
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

Aurora 50.0a2:
Build ID 	20160807004000
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160803]
I have reproduced this bug with Nightly 50.0a1 (2016-07-24) on Windows 8.1 , 64 bit!

This Bug's fix is verified on Latest Aurora 50.0a2 and Latest Nightly 51.0a1 .

Aurora 50.0a2:
Build ID : 20160810004000
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0

Nightly 51.0a1 :
Build ID : 20160810030202
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160810]
As this bug verified on both windows (Comment 16) and Linux (Comment 15) marking this bug as verified.
Status: RESOLVED → VERIFIED
QA Whiteboard: [bugday-20160810]
status-firefox50: fixed → verified
status-firefox51: fixed → verified
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.