Closed Bug 1289005 Opened 5 years ago Closed 5 years ago

Crash in mozilla::gl::GetBytesPerTexel


(Core :: Graphics, defect)

Not set



Tracking Status
firefox50 --- fixed


(Reporter: n.nethercote, Assigned: jnicol)



(Keywords: crash, topcrash-android-armv7, Whiteboard: [gfx-noted])

Crash Data


(1 file)

This bug was filed from the Socorro interface and is 
report bp-5b23d907-3ae8-4798-81f0-b66cc2160725.

New Fennec #1 topcrash. First showed up in Nightly 20160722030235, where it occurred 28 times, which is a *lot* for Fennec.

It's a MOZ_CRASH() in GetBytesPerTexel(). Looks like some kind of case isn't being handled correctly. Bug 1164027 is almost certainly the cause.

jnicol, can you please investigate?
Flags: needinfo?(jnicol)
Looks like something uses some texture formats which GLUploadHelpers.cpp code doesn't, and now this function is being used in more places it needs to be expanded to handle those cases.

All of the reports are crashing on type=GL_UNSIGNED_BYTE and format=GL_BGRA_EXT. I'll add that to the function. And I think we should remove the MOZ_CRASH. The gfxCriticalError will still assert in debug builds.
Flags: needinfo?(jnicol)
Assignee: nobody → jnicol
Also, do not MOZ_CRASH for unknown types and formats. The
gfxCriticalError will assert in debug builds and provide the values of
unknown types or formats.

Review commit:
See other reviews:
Attachment #8774336 - Flags: review?(snorp)
This crash also appears in the WebRTC Autophone job, see for instance:

You can create a try run for Autophone like this one if you want to test your fix:
Patch tested locally on a crashing url, can confirm it works. Let's check this in.
Keywords: checkin-needed
Thank you for the fast fix.
Pushed by
Handle GL_BGRA_EXT in GetBytesPerTexel; r=snorp
Keywords: checkin-needed
landed, will see that i retrigger nightlys to get this fix out to the nightly tester community when this patch hits m-c
Flags: needinfo?(cbook)
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
0 crashes reported yet with a build after 2016-07-26.
Whiteboard: [gfx-noted]
Flags: needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.