1289005 - Crash in mozilla::gl::GetBytesPerTexel

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-5b23d907-3ae8-4798-81f0-b66cc2160725.
=============================================================

New Fennec #1 topcrash. First showed up in Nightly 20160722030235, where it occurred 28 times, which is a *lot* for Fennec.

It's a MOZ_CRASH() in GetBytesPerTexel(). Looks like some kind of case isn't being handled correctly. Bug 1164027 is almost certainly the cause.

jnicol, can you please investigate?

Comment 1

[Jamie Nicol [:jnicol]]

Looks like something uses some texture formats which GLUploadHelpers.cpp code doesn't, and now this function is being used in more places it needs to be expanded to handle those cases.

All of the reports are crashing on type=GL_UNSIGNED_BYTE and format=GL_BGRA_EXT. I'll add that to the function. And I think we should remove the MOZ_CRASH. The gfxCriticalError will still assert in debug builds.

Comment 2

[Jamie Nicol [:jnicol]]

Attachment: Bug 1289005 - Handle GL_BGRA_EXT in GetBytesPerTexel;

Also, do not MOZ_CRASH for unknown types and formats. The
gfxCriticalError will assert in debug builds and provide the values of
unknown types or formats.

Review commit: https://reviewboard.mozilla.org/r/66820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66820/

Comment 3

[Dan Minor [:dminor]]

This crash also appears in the WebRTC Autophone job, see for instance: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e28e856b987380f55d699092f11f6997378f79a6&selectedJob=4430368

You can create a try run for Autophone like this one if you want to test your fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b7b4cdd4f5a80e0d7dfde4e61b54a1bc9e8c895

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8774336 [details]
Bug 1289005 - Handle GL_BGRA_EXT in GetBytesPerTexel;

https://reviewboard.mozilla.org/r/66820/#review63628

Comment 5

[Jamie Nicol [:jnicol]]

Patch tested locally on a crashing url, can confirm it works. Let's check this in.

Comment 6

[Nicholas Nethercote [inactive]]

Thank you for the fast fix.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5af04e12e860
Handle GL_BGRA_EXT in GetBytesPerTexel; r=snorp

Comment 8

[Carsten Book [:Tomcat]]

landed, will see that i retrigger nightlys to get this fix out to the nightly tester community when this patch hits m-c

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5af04e12e860

Comment 11

[u279076]

0 crashes reported yet with a build after 2016-07-26.