1289051 - Add JS_ReportError*Latin1 variants

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

(derived from bug 1283710)

JS_ReportError* without "UC" suffix is ASCII variant, but actually accepts Latin1.
So, we'd better add Latin1 variant and use it instead.

the plan is following:
  1. Add Latin1 variant
  2. Use Latin1 in consumers
  3. Remove ASCII variant

Comment 1

[Tooru Fujisawa [:arai]]

> 2. Use Latin1 in consumers
actually, use Latin1 variant in consumers, and fix if non-Latin1 encoding is used.

Comment 2

[Tooru Fujisawa [:arai]]

updated.

  1. Add Latin1 variant
  2. Add UTF8 variant
  3. Use Latin1 or UTF8 in consumers, depending each case
  4. Remove ASCII variant

If the consumer uses pure ASCII, it should be replaced with UTF8, to avoid the conversion from Latin1 to UTF8.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Add JS_ReportError*Latin1 variants.

This is just a copy of the ASCII variant of JS_ReportError*, that is using ArgumentsAreASCII (that is actually Latin1).

To replace the consumer of ASCII variant to use either Latin1 or UTF8 variant incrementally, added Latin1 variant instead of renaming ASCII variant to Latin1.

ASCII variant will be removed in bug 1289050, after replacing all consumers.

Comment 4

[Tom S [:evilpie]]

Comment on attachment 8781244 [details] [diff] [review]
Add JS_ReportError*Latin1 variants.

Review of attachment 8781244 [details] [diff] [review]:
-----------------------------------------------------------------

Ah I see. Nice to see somebody cleanup our error reporting code :)

Comment 5

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e9229e7060f1448bf5d6e6201753dd3297c3add
Bug 1289051 - Add JS_ReportError*Latin1 variants. r=evilpie

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5e9229e7060f