Add JS_ReportError*Latin1 variants

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 affected, firefox51 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
(derived from bug 1283710)

JS_ReportError* without "UC" suffix is ASCII variant, but actually accepts Latin1.
So, we'd better add Latin1 variant and use it instead.

the plan is following:
  1. Add Latin1 variant
  2. Use Latin1 in consumers
  3. Remove ASCII variant
Assignee

Comment 1

3 years ago
> 2. Use Latin1 in consumers
actually, use Latin1 variant in consumers, and fix if non-Latin1 encoding is used.
Assignee

Updated

3 years ago
Depends on: 1290422
Assignee

Comment 2

3 years ago
updated.

  1. Add Latin1 variant
  2. Add UTF8 variant
  3. Use Latin1 or UTF8 in consumers, depending each case
  4. Remove ASCII variant

If the consumer uses pure ASCII, it should be replaced with UTF8, to avoid the conversion from Latin1 to UTF8.
Assignee

Updated

3 years ago
Assignee: nobody → arai.unmht
Assignee

Comment 3

3 years ago
This is just a copy of the ASCII variant of JS_ReportError*, that is using ArgumentsAreASCII (that is actually Latin1).

To replace the consumer of ASCII variant to use either Latin1 or UTF8 variant incrementally, added Latin1 variant instead of renaming ASCII variant to Latin1.

ASCII variant will be removed in bug 1289050, after replacing all consumers.
Attachment #8781244 - Flags: review?(evilpies)
Comment on attachment 8781244 [details] [diff] [review]
Add JS_ReportError*Latin1 variants.

Review of attachment 8781244 [details] [diff] [review]:
-----------------------------------------------------------------

Ah I see. Nice to see somebody cleanup our error reporting code :)
Attachment #8781244 - Flags: review?(evilpies) → review+

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5e9229e7060f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.