Move methods such as nsRuleNode::GetShadow(), etc. as static functions to nsRuleNode.cpp

RESOLVED FIXED in Firefox 50

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
File per bug 1288626 comment 3:

Move GetShadowData, GetStyleBasicShapeFromCSSValue, SetStyleFilterToCSSValue, SetStyleClipPathToCSSValue to nsRuleNode.cpp since these functions don't need to access anything on nsRuleNode.cpp.
(Assignee)

Comment 1

a year ago
Created attachment 8774285 [details]
Bug 1289052 - Move nsRuleNode methods as static functions to .cpp file.

Review commit: https://reviewboard.mozilla.org/r/66804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66804/
Attachment #8774285 - Flags: review?(cam)
Comment on attachment 8774285 [details]
Bug 1289052 - Move nsRuleNode methods as static functions to .cpp file.

https://reviewboard.mozilla.org/r/66804/#review63570

Looks good, thanks.
Attachment #8774285 - Flags: review?(cam) → review+
(Assignee)

Comment 3

a year ago
This bug blocks bug 1288626 since SetStyleShapeOutsideToCSSValue() calls GetStyleBasicShapeFromCSSValue(), and the latter needs to become a static function before the former.
Blocks: 1288626

Comment 4

a year ago
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcf088f6097c
Move nsRuleNode methods as static functions to .cpp file. r=heycam

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fcf088f6097c
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.