Closed
Bug 1289052
Opened 8 years ago
Closed 8 years ago
Move methods such as nsRuleNode::GetShadow(), etc. as static functions to nsRuleNode.cpp
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(1 file)
File per bug 1288626 comment 3:
Move GetShadowData, GetStyleBasicShapeFromCSSValue, SetStyleFilterToCSSValue, SetStyleClipPathToCSSValue to nsRuleNode.cpp since these functions don't need to access anything on nsRuleNode.cpp.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/66804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66804/
Attachment #8774285 -
Flags: review?(cam)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8774285 [details]
Bug 1289052 - Move nsRuleNode methods as static functions to .cpp file.
https://reviewboard.mozilla.org/r/66804/#review63570
Looks good, thanks.
Attachment #8774285 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
This bug blocks bug 1288626 since SetStyleShapeOutsideToCSSValue() calls GetStyleBasicShapeFromCSSValue(), and the latter needs to become a static function before the former.
Blocks: 1288626
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcf088f6097c
Move nsRuleNode methods as static functions to .cpp file. r=heycam
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•