Move methods such as nsRuleNode::GetShadow(), etc. as static functions to nsRuleNode.cpp

RESOLVED FIXED in Firefox 50

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

Trunk
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

File per bug 1288626 comment 3:

Move GetShadowData, GetStyleBasicShapeFromCSSValue, SetStyleFilterToCSSValue, SetStyleClipPathToCSSValue to nsRuleNode.cpp since these functions don't need to access anything on nsRuleNode.cpp.
Comment on attachment 8774285 [details]
Bug 1289052 - Move nsRuleNode methods as static functions to .cpp file.

https://reviewboard.mozilla.org/r/66804/#review63570

Looks good, thanks.
Attachment #8774285 - Flags: review?(cam) → review+
This bug blocks bug 1288626 since SetStyleShapeOutsideToCSSValue() calls GetStyleBasicShapeFromCSSValue(), and the latter needs to become a static function before the former.
Blocks: 1288626
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcf088f6097c
Move nsRuleNode methods as static functions to .cpp file. r=heycam
https://hg.mozilla.org/mozilla-central/rev/fcf088f6097c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.