Closed Bug 1289052 Opened 4 years ago Closed 4 years ago
Move methods such as ns
Rule Node::Get Shadow(), etc . as static functions to ns Rule Node .cpp
58 bytes, text/x-review-board-request
File per bug 1288626 comment 3: Move GetShadowData, GetStyleBasicShapeFromCSSValue, SetStyleFilterToCSSValue, SetStyleClipPathToCSSValue to nsRuleNode.cpp since these functions don't need to access anything on nsRuleNode.cpp.
Review commit: https://reviewboard.mozilla.org/r/66804/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/66804/
Attachment #8774285 - Flags: review?(cam)
Comment on attachment 8774285 [details] Bug 1289052 - Move nsRuleNode methods as static functions to .cpp file. https://reviewboard.mozilla.org/r/66804/#review63570 Looks good, thanks.
Attachment #8774285 - Flags: review?(cam) → review+
This bug blocks bug 1288626 since SetStyleShapeOutsideToCSSValue() calls GetStyleBasicShapeFromCSSValue(), and the latter needs to become a static function before the former.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/fcf088f6097c Move nsRuleNode methods as static functions to .cpp file. r=heycam
You need to log in before you can comment on or make changes to this bug.