1289168 - Add a lint for contributors.json

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect)

Description

[James Graham [:jgraham]]

If we have to do this for HTTP Observatory then we should lint the file in development. This just means adding jsonschema to the requirements file, adding https://raw.githubusercontent.com/mozilla/contribute.json/master/schema.json to the repo and adding 

import json
import sys
from jsonschema import validate

schema = json.load(open("schema.json"))
data = json.load(open("contributing.json"))

try:
    validate(data, schema)
except Exception as e:
    print >> sys.stderr, e.args[0]
    sys.exit(1)

Comment 1

[Ed Morley [:emorley]]

What are our thoughts on just removing the contribute.json file entirely?
Is it actually seeing any traction / adding any value?

Comment 2

[Ed Morley [:emorley]]

I've had some more thoughts on contribute.json, which I've added here:
https://github.com/mozilla/http-observatory/issues/81#issuecomment-339513196

Comment 3

[Ed Morley [:emorley]]

I don't think this file changes often enough to warrant specific linting. (Generic linting of *.json in-repo on the other hand might be nice, though we'd have to exclude the json-e content in schemas/)