Closed Bug 1289283 Opened 8 years ago Closed 8 years ago

The About dialog shows a nonresponsive "Check for updates" button when an update has been applied and the Software Update window is open

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

The "Restart Firefox" button should be the button shown, because the update has been staged and Firefox just needs to restart to complete the update.

This is happening because a call to `this.isApplied` was added in bug 1286930, but the getter for `this.isApplied` references `this.um` which isn't defined until the lazy service getter defines it about 10 lines after the new call to `this.isApplied`.
Attachment #8774607 - Flags: review?(robert.strong.bugs) → review?(gijskruitbosch+bugs)
Attachment #8774607 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8774607 [details]
Bug 1289283 - Define the lazy service getters at the beginning of the appUpdater function to ensure that they are available to any code that may reference them.

https://reviewboard.mozilla.org/r/67062/#review64092

This is trival, rs=me .
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5265995a809b
Define the lazy service getters at the beginning of the appUpdater function to ensure that they are available to any code that may reference them. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/5265995a809b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: