The About dialog shows a nonresponsive "Check for updates" button when an update has been applied and the Software Update window is open

RESOLVED FIXED in Firefox 50

Status

()

Firefox
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Trunk
Firefox 50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

The "Restart Firefox" button should be the button shown, because the update has been staged and Firefox just needs to restart to complete the update.

This is happening because a call to `this.isApplied` was added in bug 1286930, but the getter for `this.isApplied` references `this.um` which isn't defined until the lazy service getter defines it about 10 lines after the new call to `this.isApplied`.
Created attachment 8774607 [details]
Bug 1289283 - Define the lazy service getters at the beginning of the appUpdater function to ensure that they are available to any code that may reference them.

Review commit: https://reviewboard.mozilla.org/r/67062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67062/
Attachment #8774607 - Flags: review?(robert.strong.bugs)

Updated

2 years ago
Attachment #8774607 - Flags: review?(robert.strong.bugs) → review?(gijskruitbosch+bugs)

Updated

2 years ago
Attachment #8774607 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 2

2 years ago
Comment on attachment 8774607 [details]
Bug 1289283 - Define the lazy service getters at the beginning of the appUpdater function to ensure that they are available to any code that may reference them.

https://reviewboard.mozilla.org/r/67062/#review64092

This is trival, rs=me .

Comment 3

2 years ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5265995a809b
Define the lazy service getters at the beginning of the appUpdater function to ensure that they are available to any code that may reference them. r=Gijs

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5265995a809b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.