1289283 - The About dialog shows a nonresponsive "Check for updates" button when an update has been applied and the Software Update window is open

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The "Restart Firefox" button should be the button shown, because the update has been staged and Firefox just needs to restart to complete the update.

This is happening because a call to `this.isApplied` was added in bug 1286930, but the getter for `this.isApplied` references `this.um` which isn't defined until the lazy service getter defines it about 10 lines after the new call to `this.isApplied`.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1289283 - Define the lazy service getters at the beginning of the appUpdater function to ensure that they are available to any code that may reference them.

Review commit: https://reviewboard.mozilla.org/r/67062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67062/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8774607 [details]
Bug 1289283 - Define the lazy service getters at the beginning of the appUpdater function to ensure that they are available to any code that may reference them.

https://reviewboard.mozilla.org/r/67062/#review64092

This is trival, rs=me .

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5265995a809b
Define the lazy service getters at the beginning of the appUpdater function to ensure that they are available to any code that may reference them. r=Gijs

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5265995a809b