1289292 - [Presentation WebAPI] terminate PresentationConnection locally while fail to establish control channel

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

In current m-c, PresentationSessionInfo::Close didn't handle failure during control channel establishment.

https://hg.mozilla.org/mozilla-central/file/tip/dom/presentation/PresentationSessionInfo.cpp#l303

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: local-terminate-while-fail.patch

Make sure |Shutdown| is invoked when fail to establish control channel or fail to send terminate command.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=be39aa88a59e

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8774981 [details] [diff] [review]
local-terminate-while-fail.patch

>+function testConnectionAvailable() {
>+  return new Promise(function(aResolve, aReject) {
>+    info('Receiver: --- testConnectionAvailable ---');
>+    ok(navigator.presentation, 'Receiver: navigator.presentation should be available.');
>+    ok(navigator.presentation.receiver, 'Receiver: navigator.presentation.receiver should be available.');
>+
>+    navigator.presentation.receiver.connectionList
>+    .then((aList) => {
>+      is(aList.connections.length, 1, 'Should get one conncetion.');
connection

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: local-terminate-while-fail.patch

update according to review comment, carry r+.

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: pull request for tv 2.6

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1276378
User impact if declined: cannot initiate page terminate on receiver side
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: n/a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4730019ab44c
Shutdown session info while fail to establish control channel. r=smaug

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4730019ab44c

Comment 8

[Josh Cheng [:josh]]

Comment on attachment 8775407 [details] [review]
pull request for tv 2.6

Approve for TV2.6

Comment 9

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8775407 [details] [review]
pull request for tv 2.6

ni @xeonchen for uplift.

Comment 10

[Gary Chen [:xeonchen]]

https://github.com/mozilla-b2g/gecko-b2g/commit/2410b6a3dd70f8fb5188d264412b6e61d6be3ce6