1289375 - Rollback the change of preloading cursors for IndexedDB

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P1)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

Patch#4 and Patch#5 of bug 1168606 seems incomplete and are dead codes.
Furthermore, they seems not validated before landing. :-(
In Patch#5, 
The extra ExecuteStep [1] is useless because the number of queried results are already LIMITed in [2] and we met further assertion failure in PopulateResponseFromStatement() if we set countString in [1] as advanceCount + extraCount.
That means changes in ActorsChild.cpp has never been executed.

In addition, changes in patch#4 is also useless because the additional key parameter has never been used.

To prevent further confusion while implementing bug 1271505.
I'd like to roll back these 2 patches and reopen bug 1168606 to follow up.

[1] https://hg.mozilla.org/mozilla-central/file/tip/dom/indexedDB/ActorsParent.cpp#l27848
[2] https://hg.mozilla.org/mozilla-central/file/tip/dom/indexedDB/ActorsParent.cpp#l27766

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Patch: Rollback incomplete change of preloading cursors for IndexedDB.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8774696 [details] [diff] [review]
(v1) Patch: Rollback incomplete change of preloading cursors for IndexedDB.

Review of attachment 8774696 [details] [diff] [review]:
-----------------------------------------------------------------

Treeherder result for reference:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d04948efc499

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

treeherder result looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef2e942e1978&selectedJob=25003016

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eda36a4f9303
Rollback incomplete change of preloading cursors for IndexedDB. r=khuey

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eda36a4f9303