If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

mGenerateComputedGridInfo needs default value in constructor to pass clang analysis

RESOLVED FIXED in Firefox 50

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bradwerth, Assigned: bradwerth)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Bug 1282408 clang analysis fails since mGenerateComputedGridInfo does not get a value during construction. Default value should be false.
(Assignee)

Comment 1

a year ago
Created attachment 8774808 [details] [diff] [review]
defaultValue1.patch

Supplies a default value for mGenerateComputedGridInfo.
Attachment #8774808 - Flags: review?(bzbarsky)
Attachment #8774808 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 2

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11bad8ea414c
Supply a default value for mGenerateComputedGridInfo. r=bz
Keywords: checkin-needed

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/11bad8ea414c
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.