Closed Bug 1289509 Opened 8 years ago Closed 8 years ago

mGenerateComputedGridInfo needs default value in constructor to pass clang analysis

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: bradwerth, Assigned: bradwerth)

References

Details

Attachments

(1 file)

defaultValue1.patch
1.27 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
Bug 1282408 clang analysis fails since mGenerateComputedGridInfo does not get a value during construction. Default value should be false.
Supplies a default value for mGenerateComputedGridInfo.
Attachment #8774808 - Flags: review?(bzbarsky)
Attachment #8774808 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11bad8ea414c
Supply a default value for mGenerateComputedGridInfo. r=bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/11bad8ea414c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: