1289590 - Implement Activity Stream Simple Highlight Cell for New Tab Page

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect, P1)

Description

[Bryan Munar (:bkmunar)]

This cell is for Synced Tabs/Recent Bookmarks/Recent Tabs

Comment 1

[Bryan Munar (:bkmunar)]

These should be UICollectionViewCells

Comment 2

[Farhan Patel [:farhan]]

master 3cbecef2c9bd880d4ad26d6674421cbd03610b7c

Comment 3

[Stefan Plewako [:stef]]

It could be impossible to translate strings for this bug, https://github.com/splewako/mozilla-l10n-en/commit/9fb74e6cccc94dce7716d4a99023a90fa3146729 correctly (or in a way that is not awkward) into some locales.

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

(In reply to Stefan Plewako [:stef] from comment #3)
> It could be impossible to translate strings for this bug,
> https://github.com/splewako/mozilla-l10n-en/commit/
> 9fb74e6cccc94dce7716d4a99023a90fa3146729 correctly (or in a way that is not
> awkward) into some locales.

I agree. 
Also, this bug is confusing. It's hard to tell what is going on here as there is basically no information and no comments explaining. Also, no merge link?

Comment 5

[Stephan Leroux [:sleroux]]

> Also, this bug is confusing. It's hard to tell what is going on here as there is basically no information and no comments explaining. Also, no merge link?

My apologies. This bug was created to track a finer-grained engineering task and the patch that was merged contains many resolved bugs. I'll create a new bug reflecting the l10n work needed for the overall feature we're implementing through these bugs.

Comment 6

[Stephan Leroux [:sleroux]]

Instead of creating a new bug, the string changes are only needed for this task so I'll link the details here:

Merge commit: https://github.com/mozilla/firefox-ios/commit/fdc3684c7c071328eb40bda08a8740dbec6fff41
Strings in question for this feature: https://github.com/mozilla/firefox-ios/commit/fdc3684c7c071328eb40bda08a8740dbec6fff41#diff-2ba1a7ac69104fb71084b67b734b8ca1R49

In particular, the various plural forms for the 'X time ago' strings. We plan on showing these strings on the new Activity Stream panel cells for the recent history items:

https://mozilla.invisionapp.com/share/6Q8CRFR8B#/screens/182975840

We currently show similar strings in your Synced Devices screen (for how long ago you're device was synced) and in the Settings screen showing how long it has been since a user has synced their account. Unfortunately this isn't a good way of handling plural forms so at this point we'll probably need to implement https://bugzilla.mozilla.org/show_bug.cgi?id=1181777 in order for this to work.

Comment 7

[Francesco Lodolo [:flod]]

We use "more than a month ago", "this week" for that very reason, not something that is associated to a number, es "x days ago".

As Stef said, these are basically not localizable right now. Just imagine to only have one string that says "X hours ago", instead of the two you artificially created, and show "1 hours ago" to users.

Comment 8

[Stephan Leroux [:sleroux]]

> We use "more than a month ago", "this week" for that very reason, not something that is associated to a number, es "x days ago".

Ah yes I forgot we made that change a while ago. I'll file a new bug to revert this change.