Closed
Bug 1289655
Opened 8 years ago
Closed 8 years ago
1.0.4 failure: conformance/rendering/negative-one-index.html
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(5 files)
|
58 bytes,
text/x-review-board-request
|
mtseng
:
review+
ritu
:
approval-mozilla-beta+
|
Details |
|
58 bytes,
text/x-review-board-request
|
mtseng
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
mtseng
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
mtseng
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/67342/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67342/
Attachment #8774994 -
Flags: review?(mtseng)
|
||
Updated•8 years ago
|
Attachment #8774994 -
Flags: review?(mtseng) → review+
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8774994 [details] Bug 1289655 - Add primitive restart for WebGL 2. - https://reviewboard.mozilla.org/r/67342/#review64690
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68104/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68104/
Attachment #8774994 -
Attachment description: Bug 1289655 - Primitive restart should always be enabled in WebGL 2. - → Bug 1289655 - Add primitive restart for WebGL 2. -
Attachment #8776199 -
Flags: review?(mtseng)
Attachment #8776200 -
Flags: review?(mtseng)
Attachment #8776201 -
Flags: review?(mtseng)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68106/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68106/
|
|
Assignee | |
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68108/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68108/
|
|
Assignee | |
Comment 6•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68110/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68110/
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8774994 [details] Bug 1289655 - Add primitive restart for WebGL 2. - Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67342/diff/1-2/
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8776199 [details] Bug 1289655 - Add prim_restart and prim_restart_fixed GLFeatures. - https://reviewboard.mozilla.org/r/68104/#review65278
Attachment #8776199 -
Flags: review?(mtseng) → review+
|
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8776200 [details] Bug 1289655 - Organize GLFeature checks for WebGL2. - https://reviewboard.mozilla.org/r/68106/#review65280
Attachment #8776200 -
Flags: review?(mtseng) → review+
|
|
||
Updated•8 years ago
|
Attachment #8776201 -
Flags: review?(mtseng) → review+
|
|
||
Comment 10•8 years ago
|
||
Comment on attachment 8776201 [details] Bug 1289655 - Use UINT32_MAX for drawArrays because of OSX. - https://reviewboard.mozilla.org/r/68108/#review65282
|
||
Comment 11•8 years ago
|
||
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a6cb5fa71803 Add prim_restart and prim_restart_fixed GLFeatures. - r=mtseng https://hg.mozilla.org/integration/mozilla-inbound/rev/d9c15335cb2c Organize GLFeature checks for WebGL2. - r=mtseng https://hg.mozilla.org/integration/mozilla-inbound/rev/72904d652e9a Add primitive restart for WebGL 2. - r=mtseng https://hg.mozilla.org/integration/mozilla-inbound/rev/33a6f68fdddd Use UINT32_MAX for drawArrays because of OSX. - r=mtseng https://hg.mozilla.org/integration/mozilla-inbound/rev/00ec649c5c61 Mark test.
|
||
Comment 12•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a6cb5fa71803 https://hg.mozilla.org/mozilla-central/rev/d9c15335cb2c https://hg.mozilla.org/mozilla-central/rev/72904d652e9a https://hg.mozilla.org/mozilla-central/rev/33a6f68fdddd https://hg.mozilla.org/mozilla-central/rev/00ec649c5c61
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
|
Assignee | |
Updated•8 years ago
|
Blocks: webgl2-slipped-50
|
|
Assignee | |
Comment 13•8 years ago
|
||
Comment on attachment 8774994 [details] Bug 1289655 - Add primitive restart for WebGL 2. - Approval Request Comment [Feature/regressing bug #]: WebGL 2 [User impact if declined]: Blocks WebGL 2 blockers [Describe test coverage new/current, TreeHerder]: Conformance suite. [Risks and why]: very low [String/UUID change made/needed]: none
Attachment #8774994 -
Flags: approval-mozilla-beta?
Comment on attachment 8774994 [details] Bug 1289655 - Add primitive restart for WebGL 2. - WebGL2 related, Beta50+
Attachment #8774994 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
This hit conflicts uplifting to beta, could we get rebased patches?
Flags: needinfo?(jgilbert)
|
|
Assignee | |
Comment 16•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/2c0795d4b1b0e83b31136fd217f9d237dd4d7031
Flags: needinfo?(jgilbert)
|
||
Comment 17•8 years ago
|
||
This caused a performance regression on the In Limbo WebGL 2 demo, marked that down as https://bugzilla.mozilla.org/show_bug.cgi?id=1309643
You need to log in
before you can comment on or make changes to this bug.
Description
•