Closed Bug 1289655 Opened 3 years ago Closed 3 years ago

1.0.4 failure: conformance/rendering/negative-one-index.html

Categories

(Core :: Canvas: WebGL, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

No description provided.
Attachment #8774994 - Flags: review?(mtseng) → review+
Review commit: https://reviewboard.mozilla.org/r/68104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68104/
Attachment #8774994 - Attachment description: Bug 1289655 - Primitive restart should always be enabled in WebGL 2. - → Bug 1289655 - Add primitive restart for WebGL 2. -
Attachment #8776199 - Flags: review?(mtseng)
Attachment #8776200 - Flags: review?(mtseng)
Attachment #8776201 - Flags: review?(mtseng)
Comment on attachment 8774994 [details]
Bug 1289655 - Add primitive restart for WebGL 2. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67342/diff/1-2/
Comment on attachment 8776199 [details]
Bug 1289655 - Add prim_restart and prim_restart_fixed GLFeatures. -

https://reviewboard.mozilla.org/r/68104/#review65278
Attachment #8776199 - Flags: review?(mtseng) → review+
Comment on attachment 8776200 [details]
Bug 1289655 - Organize GLFeature checks for WebGL2. -

https://reviewboard.mozilla.org/r/68106/#review65280
Attachment #8776200 - Flags: review?(mtseng) → review+
Attachment #8776201 - Flags: review?(mtseng) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6cb5fa71803
Add prim_restart and prim_restart_fixed GLFeatures. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9c15335cb2c
Organize GLFeature checks for WebGL2. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/72904d652e9a
Add primitive restart for WebGL 2. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/33a6f68fdddd
Use UINT32_MAX for drawArrays because of OSX. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/00ec649c5c61
Mark test.
Comment on attachment 8774994 [details]
Bug 1289655 - Add primitive restart for WebGL 2. -

Approval Request Comment
[Feature/regressing bug #]: WebGL 2
[User impact if declined]: Blocks WebGL 2 blockers
[Describe test coverage new/current, TreeHerder]: Conformance suite.
[Risks and why]: very low
[String/UUID change made/needed]: none
Attachment #8774994 - Flags: approval-mozilla-beta?
Blocks: 1303879
Comment on attachment 8774994 [details]
Bug 1289655 - Add primitive restart for WebGL 2. -

WebGL2 related, Beta50+
Attachment #8774994 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
This hit conflicts uplifting to beta, could we get rebased patches?
Flags: needinfo?(jgilbert)
This caused a performance regression on the In Limbo WebGL 2 demo, marked that down as https://bugzilla.mozilla.org/show_bug.cgi?id=1309643
Blocks: 1309643
Blocks: 1310219
You need to log in before you can comment on or make changes to this bug.