1289655 - 1.0.4 failure: conformance/rendering/negative-one-index.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1289655 - Add primitive restart for WebGL 2. -

Review commit: https://reviewboard.mozilla.org/r/67342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67342/

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8774994 [details]
Bug 1289655 - Add primitive restart for WebGL 2. -

https://reviewboard.mozilla.org/r/67342/#review64690

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1289655 - Add prim_restart and prim_restart_fixed GLFeatures. -

Review commit: https://reviewboard.mozilla.org/r/68104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68104/

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1289655 - Organize GLFeature checks for WebGL2. -

Review commit: https://reviewboard.mozilla.org/r/68106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68106/

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1289655 - Use UINT32_MAX for drawArrays because of OSX. -

Review commit: https://reviewboard.mozilla.org/r/68108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68108/

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1289655 - Mark test.

Review commit: https://reviewboard.mozilla.org/r/68110/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68110/

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8774994 [details]
Bug 1289655 - Add primitive restart for WebGL 2. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67342/diff/1-2/

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8776199 [details]
Bug 1289655 - Add prim_restart and prim_restart_fixed GLFeatures. -

https://reviewboard.mozilla.org/r/68104/#review65278

Comment 9

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8776200 [details]
Bug 1289655 - Organize GLFeature checks for WebGL2. -

https://reviewboard.mozilla.org/r/68106/#review65280

Comment 10

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8776201 [details]
Bug 1289655 - Use UINT32_MAX for drawArrays because of OSX. -

https://reviewboard.mozilla.org/r/68108/#review65282

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6cb5fa71803
Add prim_restart and prim_restart_fixed GLFeatures. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9c15335cb2c
Organize GLFeature checks for WebGL2. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/72904d652e9a
Add primitive restart for WebGL 2. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/33a6f68fdddd
Use UINT32_MAX for drawArrays because of OSX. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/00ec649c5c61
Mark test.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a6cb5fa71803
https://hg.mozilla.org/mozilla-central/rev/d9c15335cb2c
https://hg.mozilla.org/mozilla-central/rev/72904d652e9a
https://hg.mozilla.org/mozilla-central/rev/33a6f68fdddd
https://hg.mozilla.org/mozilla-central/rev/00ec649c5c61

Comment 13

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8774994 [details]
Bug 1289655 - Add primitive restart for WebGL 2. -

Approval Request Comment
[Feature/regressing bug #]: WebGL 2
[User impact if declined]: Blocks WebGL 2 blockers
[Describe test coverage new/current, TreeHerder]: Conformance suite.
[Risks and why]: very low
[String/UUID change made/needed]: none

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8774994 [details]
Bug 1289655 - Add primitive restart for WebGL 2. -

WebGL2 related, Beta50+

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This hit conflicts uplifting to beta, could we get rebased patches?

Comment 16

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c0795d4b1b0e83b31136fd217f9d237dd4d7031

Comment 17

[Jukka Jylänki]

This caused a performance regression on the In Limbo WebGL 2 demo, marked that down as https://bugzilla.mozilla.org/show_bug.cgi?id=1309643