Closed
Bug 1289779
Opened 8 years ago
Closed 7 years ago
Make sure that different docker-image tasks use different job symbols
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla53
People
(Reporter: whimboo, Assigned: hammad13060, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
Right now all the docker image tasks on TC use the job symbol `I`, which makes it hard to identify which docker image is actually build. It would be great if we can have different symbols for easier inspection on Treeherder.
Updated•8 years ago
|
Mentor: dustin
Keywords: good-first-bug
Comment 1•8 years ago
|
||
This would involve making some modifications under taskcluster/ci/docker-image and/or taskcluster/taskgraph/task/docker_image.py. There are docs under taskcluster/docs/ and also https://docs.taskcluster.net/tutorial. I'll be happy to fill in gaps.
Comment 2•7 years ago
|
||
Hammad, if I remember correctly, you said you were hacking on this because it was a dependency of one of the verification bugs.
Assignee: nobody → hammad13060
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8818199 [details] Bug 1289779 - Make sure that different docker-image tasks use different job symbols; https://reviewboard.mozilla.org/r/98336/#review98594 You're on a roll! ::: taskcluster/ci/docker-image/kind.yml:14 (Diff revision 1) > - - desktop-test > - - desktop1604-test > - - desktop-build > - - tester > - - lint > - - android-gradle-build > + desktop-test: A > + desktop1604-test: B > + desktop-build: C > + tester: D > + lint: E > + android-gradle-build: F Please invent some shorthands here that remind people what they mean -- something like "dt" for desktop-test, etc. ::: taskcluster/taskgraph/task/docker_image.py:73 (Diff revision 1) > + if 'extra' in image_task['task']: > + image_task['task']['extra']['treeherder']['symbol'] += image_symbol Let's make this a taskGroup, so each task looks like I(dt) I(d16t) I(db) etc..
Attachment #8818199 -
Flags: review?(dustin)
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8818199 [details] Bug 1289779 - Make sure that different docker-image tasks use different job symbols; https://reviewboard.mozilla.org/r/98336/#review98614 ::: taskcluster/ci/docker-image/kind.yml:14 (Diff revision 1) > - - desktop-test > - - desktop1604-test > - - desktop-build > - - tester > - - lint > - - android-gradle-build > + desktop-test: A > + desktop1604-test: B > + desktop-build: C > + tester: D > + lint: E > + android-gradle-build: F how about following naming desktop-test: dt desktop1604-test: d16t desktop-build: db tester: tst lint: lnt android-gradle-build: agb ::: taskcluster/taskgraph/task/docker_image.py:73 (Diff revision 1) > + if 'extra' in image_task['task']: > + image_task['task']['extra']['treeherder']['symbol'] += image_symbol so I should make `I` as groupSymbol and `dt` as symbol in case of desktop-build. same for other images.
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8818199 [details] Bug 1289779 - Make sure that different docker-image tasks use different job symbols; https://reviewboard.mozilla.org/r/98336/#review98614 > how about following naming > desktop-test: dt > desktop1604-test: d16t > desktop-build: db > tester: tst > lint: lnt > android-gradle-build: agb I like it. > so I should make `I` as groupSymbol > and `dt` as symbol in case of desktop-build. same for other images. Yes, exactly
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8818199 [details] Bug 1289779 - Make sure that different docker-image tasks use different job symbols; https://reviewboard.mozilla.org/r/98336/#review98636 "treeherder": { "build": { "platform": "taskcluster-images" }, "groupSymbol": "I", "jobKind": "other", "symbol": "dt" }, Looks good!
Attachment #8818199 -
Flags: review?(dustin) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8818199 [details] Bug 1289779 - Make sure that different docker-image tasks use different job symbols; https://reviewboard.mozilla.org/r/98336/#review98638 You will need to clear the two mozreview issues you've opened before I can land this.
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8818199 [details] Bug 1289779 - Make sure that different docker-image tasks use different job symbols; https://reviewboard.mozilla.org/r/98336/#review98640 Sorry if that wasn't clear -- when you replied to my comments on the review, you left the "Open an Issue" checkbox checked. Since you opened those issues, only you can close them by marking them as fixed. And I can't land the commit until all of the issues are closed.
Assignee | ||
Comment 11•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8818199 [details] Bug 1289779 - Make sure that different docker-image tasks use different job symbols; https://reviewboard.mozilla.org/r/98336/#review98640 I think I have closed all the open issues :)
Comment 12•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8818199 [details] Bug 1289779 - Make sure that different docker-image tasks use different job symbols; https://reviewboard.mozilla.org/r/98336/#review98640 Looks good -- I sent it to auto-land.
Comment 13•7 years ago
|
||
Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e06c085d1397 Make sure that different docker-image tasks use different job symbols; r=dustin
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e06c085d1397
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Reporter | ||
Comment 15•7 years ago
|
||
Dustin, can we get this uplifted to aurora so it will hit the next ESR release? Would be great given that we will support it for over a year.
Flags: needinfo?(dustin)
Comment 16•7 years ago
|
||
If you'd like, that's fine -- but how useful will this be during that time? Will ESR be generating new docker images?
Flags: needinfo?(dustin)
Reporter | ||
Comment 17•7 years ago
|
||
Frankly, I don't have an answer to this question. But if the patch applies fine on current aurora why we shouldn't try? In case of merge conflicts we could still say no.
Whiteboard: [checkin-needed-aurora]
Comment 20•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/55bfc9ee4482
Whiteboard: [checkin-needed-aurora]
Comment 21•7 years ago
|
||
Why not uplift everything that lands in central to aurora, if it applies without conflicts? I'm just confused why this came up.
Reporter | ||
Comment 22•7 years ago
|
||
Currently mozilla-aurora will become our next ESR release which will stay around for another year. That was the main reason why I asked for an uplift. In that case it helps a lot to see the different types of docker jobs when investigating issues as what I noticed the last months. Generally we do not want to uplift everything.
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•